Hi Katya,
the fix looks good to me.
-- Igor
> On Feb 27, 2018, at 9:45 AM, Ekaterina Pavlova
> wrote:
>
> Jon,
>
> thanks for the review.
> I have updated the webrev.
>
> thanks,
> -katya
>
>
> On 2/26/18 12:02 PM, Jonathan Gibbons wrote:
>> If these new problem-list files are destined fo
Jon,
thanks for the review.
I have updated the webrev.
thanks,
-katya
On 2/26/18 12:02 PM, Jonathan Gibbons wrote:
If these new problem-list files are destined for use by jtreg, I would encourage adding a
platform specifier on each line, after the bug number. If you want to mark the test as
Currently, SetupNativeCompilation takes as "main" argument either
LIBRARY := $name, PROGRAM := $name or STATIC_LIBRARY := $name.
This confounds two distinct concepts: the name of the generated binary,
and the type of binary to create. Instead, we should have a NAME
argument and a TYPE argument.