RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-04-23 Thread Michal Vala
Hi, following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm posting updated patch replacing deprecated readdir_r with readdir. Bug ID is JDK-8179887 [2]. webrev: http://cr.openjdk.java.net/~andrew/8179887/webrev/ I'm asking for the review and eventually sponsorship. Thanks! [

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-04-23 Thread David Holmes
Hi Michal, This was discussed in a couple of different threads. Please also see: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021530.html Thanks, David On 23/04/2018 5:51 PM, Michal Vala wrote: Hi, following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm posting

INCLUDE_SA/serviceability agent - support on s390x

2018-04-23 Thread Baesken, Matthias
Hello, as far as I know the serviceability agent is not supported on linux s390x . However (unlike on aix where it is not supported as well) , INCLUDE_SA=falseis not set in the central configure m4 files . Should we set it ( suggested diff below) ? Best regards, Matthias hg

Re: INCLUDE_SA/serviceability agent - support on s390x

2018-04-23 Thread Erik Joelsson
Makes sense to me. Looks good. /Erik On 2018-04-23 05:01, Baesken, Matthias wrote: Hello,   as far as I know  the serviceability agent   is not  supported on  linux s390x . However  (unlike  on aix where it is not supported as well) ,   INCLUDE_SA=false is not set  in the central configur

Re: RFR: build pragma error with gcc 4.4.7

2018-04-23 Thread Kim Barrett
> On Apr 21, 2018, at 11:18 AM, Andrew Hughes wrote: > > On 19 March 2018 at 23:23, Kim Barrett wrote: >> There are also problems with the patch as provided. >> >> (1) Since PRAGMA_DIAG_PUSH/POP do nothing in the version of gcc this >> change is being made in support of, the warning would be di

Re: RFR: build pragma error with gcc 4.4.7

2018-04-23 Thread Andrew Hughes
On 23 April 2018 at 20:19, Kim Barrett wrote: >> On Apr 21, 2018, at 11:18 AM, Andrew Hughes wrote: >> >> On 19 March 2018 at 23:23, Kim Barrett wrote: >>> There are also problems with the patch as provided. >>> >>> (1) Since PRAGMA_DIAG_PUSH/POP do nothing in the version of gcc this >>> change

Re: RFR: build pragma error with gcc 4.4.7

2018-04-23 Thread David Holmes
On 24/04/2018 1:27 PM, Andrew Hughes wrote: On 23 April 2018 at 20:19, Kim Barrett wrote: On Apr 21, 2018, at 11:18 AM, Andrew Hughes wrote: On 19 March 2018 at 23:23, Kim Barrett wrote: There are also problems with the patch as provided. (1) Since PRAGMA_DIAG_PUSH/POP do nothing in the