Re: RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests

2018-05-01 Thread Igor Ignatev
Vladimir, Tests are listed only in _quick test group b/c it doesn’t include all tests from the directory. We use this group in some of our test configurations, and :vmTestbase_nsk_monitoring in others. vmTestbase_nsk_monitoring is defined by the directory as other groups. Thanks, — Igor > On

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-05-01 Thread Andrew Hughes
On 26 April 2018 at 23:55, Kim Barrett wrote: snip... > > I disagree, and still think the perfMemory_linux.cpp change should be > removed. > > (1) The change to perfMemory_linux.cpp is entirely unnecessary to > address the problem this bug is about. > > (2) It violates

Re: RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests

2018-05-01 Thread Vladimir Kozlov
Igor, Why you need to list each test in TEST.groups and not just directory as we do in other cases? Thanks, Vladimir On 5/1/18 7:10 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html 41276 lines changed: 41274 ins; 1 del; 1 mod; Hi all, could

RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests

2018-05-01 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html > 41276 lines changed: 41274 ins; 1 del; 1 mod; Hi all, could you please review the patch which open sources monitoring tests from vm testbase? The tests were developed to test hotspot related JMX functionality. as w/ common

Re: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

2018-05-01 Thread Kim Barrett
> On Apr 30, 2018, at 8:42 PM, Kim Barrett wrote: > And it looks like there is further cleanup needed in these areas. I’ve created these followups: https://bugs.openjdk.java.net/browse/JDK-8202508 https://bugs.openjdk.java.net/browse/JDK-8202509

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-05-01 Thread Kim Barrett
> On Apr 27, 2018, at 4:26 PM, Michal Vala wrote: >>> For now, proposed patch looks like this: >>> >>> --- old/src/hotspot/os/linux/os_linux.inline.hpp2018-04-20 >>> 09:16:34.498343185 +0200 >>> +++ new/src/hotspot/os/linux/os_linux.inline.hpp2018-04-20 >>>

Re: RFR: JDK-8196113: Remove the Compact Profile builds

2018-05-01 Thread Alan Bateman
On 30/04/2018 21:19, Erik Joelsson wrote: Compact profiles were added in JDK 8, and superceded by modules in JDK 9. The build logic for compact profiles was left in place in 9, but as we head into 11 it is time to remove this. This patch removes all the build logic related to that. Bug: