Re: RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

Hi Erik, Thank you so much for investigating a proper fix for the vm_version.o issue. I will withdraw the build change from my original webrev. Thanks again for taking over the bug! Jiangli > On May 11, 2018, at 2:33 PM, Erik Joelsson wrote: > > Received: from

Re: RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

Hello, For the build change, it's very undesirable to always have to relink libjvm on every incremental build. Such a change cannot be accepted. I have a counter suggestion, which is still a bit of a hack, but it will cause vm_version.cpp to be recompiled (almost) every time libjvm.so needs

Re: 8199271: [TESTBUG] open source VM testbase stress tests

Looks good to me, Misha On 5/8/18, 2:23 PM, Leonid Mesnik wrote: Hi Please review this change open sourcing vm testbase stress tests. These tests have been developed a long time ago for internal test harness and don't looks very nice now. They are open sourced with minimal changes only. The

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

On 2018-05-10 21:56, David Holmes wrote: On 11/05/2018 10:03 AM, Erik Joelsson wrote: On 2018-05-10 15:52, David Holmes wrote: On 11/05/2018 8:41 AM, Erik Joelsson wrote: Here is a new webrev where the IGNORED are added last. http://cr.openjdk.java.net/~erikj/8202920/webrev.02/ It will

Re: RFR 8202974: Backout JDK-8202683

Pushed. Sorry for the mess! -Aleksey On 05/11/2018 05:35 PM, Erik Joelsson wrote: > Please do, thanks! > > /Erik > > > On 2018-05-11 05:39, Aleksey Shipilev wrote: >> Thanks! >> >> Erik J., want me to push this? >> >> -Aleksey >> >> On 05/11/2018 09:41 AM, Thomas Stüfe wrote: >>> Looks fine

Re: RFR 8202974: Backout JDK-8202683

Please do, thanks! /Erik On 2018-05-11 05:39, Aleksey Shipilev wrote: Thanks! Erik J., want me to push this? -Aleksey On 05/11/2018 09:41 AM, Thomas Stüfe wrote: Looks fine and trivial. .. Thomas On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote: Hi, As we can

Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 11.5.2018 12:31, Maurizio Cimadamore wrote: Thumbs up - thanks for taking the comments into account. Great job! +1 Jan Maurizio On 04/05/18 22:59, Jonathan Gibbons wrote: Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs. It

Re: RFR 8202974: Backout JDK-8202683

Thanks! Erik J., want me to push this? -Aleksey On 05/11/2018 09:41 AM, Thomas Stüfe wrote: > Looks fine and trivial. > > .. Thomas > > On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote: >> Hi, >> >> As we can see, recent fix to jvm.cfg configuration was messed up.

RE: [11] RFR for JDK-8202544: Hide unused exports in libzip

Hi Alexey, good catch, I missed that. Best regards Christoph > -Original Message- > From: Alexey Ivanov [mailto:alexey.iva...@oracle.com] > Sent: Freitag, 11. Mai 2018 13:21 > To: Langer, Christoph ; core-libs d...@openjdk.java.net>; hotspot-dev

Re: [11] RFR for JDK-8202544: Hide unused exports in libzip

Hi Christoph, Thank you for your review. I was checking the changeset before pushing and noticed I had forgotten to remove JNIEXPORT modifier from ZIP_GetEntry in zip_util.h. Here's the updated webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.1/ The only difference with

Re: RFR: 8201274: Launch Single-File Source-Code Programs

Thumbs up - thanks for taking the comments into account. Great job! Maurizio On 04/05/18 22:59, Jonathan Gibbons wrote: Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs. It includes all review feedback so far. The changes are mostly

Re: RFR 8202974: Backout JDK-8202683

Looks fine and trivial. .. Thomas On Fri, May 11, 2018 at 9:01 AM, Aleksey Shipilev wrote: > Hi, > > As we can see, recent fix to jvm.cfg configuration was messed up. Erik is > trying to fix that with > JDK-8202920 (thanks!). Meanwhile, it seems prudent to backout the

RFR 8202974: Backout JDK-8202683

Hi, As we can see, recent fix to jvm.cfg configuration was messed up. Erik is trying to fix that with JDK-8202920 (thanks!). Meanwhile, it seems prudent to backout the offending change. Backout applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8202974 Fix:

Re: RFR: JDK-8202920: jvm.cfg generation incorrect

On 05/11/2018 06:56 AM, David Holmes wrote: > On 11/05/2018 10:03 AM, Erik Joelsson wrote: >> On 2018-05-10 15:52, David Holmes wrote: >>> Given these jvm.cfg files have been slated for removal for a very long >>> time, I don't think you >>> want to add new configure options related to them. Even