Hi Leonid,
Looks good to me too.
Thanks,
Serguei
On 5/14/18 14:04, Leonid Mesnik wrote:
Misha
Thank you for review. I still need one more review from 'R'eviewer.
Leonid
On May 11, 2018, at 9:10 AM, Mikhailo Seledtsov
wrote:
Looks good to me,
Misha
On 5/8/18, 2:23 PM, Leonid Mesnik wr
Hi,
OK .. if you can convince upstream this is worth doing, then we can
accept it
as we would not regress when updating. As I noted previously :
http://mail.openjdk.java.net/pipermail/2d-dev/2018-March/009086.html
this is still an issue in the currently being developed 9c train.
-phil.
On 5/1
Build changes look good.
/Erik
On 2018-05-16 15:52, Phil Race wrote:
Webrev: http://cr.openjdk.java.net/~prr/8191522/
Bug: https://bugs.openjdk.java.net/browse/JDK-8191522
The Lucida fonts have never been part of OpenJDK but many places in
the code
and tests reference them. There are even a
Webrev: http://cr.openjdk.java.net/~prr/8191522/
Bug: https://bugs.openjdk.java.net/browse/JDK-8191522
The Lucida fonts have never been part of OpenJDK but many places in the code
and tests reference them. There are even a couple of stray fonts.dir
files that
probably should not have been in th
Sounds good.
/Erik
On 2018-05-16 14:14, Kevin Walls wrote:
Hi,
FYI, I haven't pushed this to 8u yet but am about to, with two changes
in jdk/make/CopyFiles.gmk:
define copy-and-chmod had a colon and extra space on the end of the
line. LIB_DST_DIR is not defined here in 8u, it should be
$
Hi,
FYI, I haven't pushed this to 8u yet but am about to, with two changes
in jdk/make/CopyFiles.gmk:
define copy-and-chmod had a colon and extra space on the end of the
line. LIB_DST_DIR is not defined here in 8u, it should be
$(JDK_OUTPUTDIR)/bin
Thanks
Kevin
On 26/04/2018 16:57, Erik
Build changes look good.
/Erik
On 2018-05-16 09:18, Sergey Bylokhov wrote:
Looks fine.
cc build-dev to review changes in the make file.
On 14/05/2018 14:01, Alan Snyder wrote:
http://cr.openjdk.java.net/~serb/alans/8194327/webrev.02
https://bugs.openjdk.java.net/browse/JDK-8194327
Looks fine.
cc build-dev to review changes in the make file.
On 14/05/2018 14:01, Alan Snyder wrote:
http://cr.openjdk.java.net/~serb/alans/8194327/webrev.02
https://bugs.openjdk.java.net/browse/JDK-8194327
--
Best regards, Sergey.
> 16 maj 2018 kl. 01:39 skrev Erik Joelsson :
>
> Hello,
>
> In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice.
Oops, will fix.
> Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we
> should be moving them to one place? Regardless, I think we need an INCLUDE in
> the S
Hi Matthias,
yes, reviewed.
Best regards
Christoph
From: Baesken, Matthias
Sent: Mittwoch, 16. Mai 2018 09:06
To: Langer, Christoph ; 'build-dev@openjdk.java.net'
; ppc-aix-port-...@openjdk.java.net;
core-libs-...@openjdk.java.net
Cc: Lindenmaier, Goetz
Subject: RE: RFR : 8202322: AIX: symbol
Hi Christoph can I add you as second reviewer (other reviewer was Erik
Joelsson) can push the change ?
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 26. April 2018 16:38
To: Baesken, Matthias ; 'build-dev@openjdk.java.net'
; ppc-aix-port-...@openjdk.java.net;
core-libs-.
11 matches
Mail list logo
