Looks like the line "# } nsk/jvmti" is a left over. Otherwise this looks
ok, even if it's an enormous amount of duplication. Hopefully we can
figure out a better way to express common parameters for tests soon.
/Erik
On 2018-05-22 16:35, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iigna
> On May 23, 2018, at 4:21 AM, Magnus Ihse Bursie
> wrote:
>
> ... but you should switch order on the chmod and the mv in the new gensrc
> file, so the mv comes last.
I thought it's safer to call CHMOD last so MV won't change file mode back. (I'm
not saying it will, just afraid.)
In below
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html
> 308253 lines changed: 308253 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JVMTI tests from VM
testbase?
As usually w/ VM testbase code, these tests are old, they have been run in
hotspot t
.. but you should switch order on the chmod and the mv in the new gensrc file,
so the mv comes last.
/Magnus
> 22 maj 2018 kl. 17:44 skrev Erik Joelsson :
>
> Build changes look ok.
>
> /Erik
>
>
>> On 2018-05-22 08:25, Weijun Wang wrote:
>> Please take a review at
>>
>>http://cr.openj
Build changes look ok.
/Erik
On 2018-05-22 08:25, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8201815/webrev.00/
With this change, We switch from a home-grown public suffix list (implemented
in sun/net/RegisteredDomain.java) to Mozilla's PSL. The PSL da
Build changes look good.
/Erik
On 2018-05-21 19:39, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk11.
Bug: https://bugs.openjdk.java.net/browse/JDK-8203308
Webrev: http://cr.openjdk.java.net/~serb/8203308/webrev.00
Description:
- Implementation of the AppletViewer was removed
Please take a review at
http://cr.openjdk.java.net/~weijun/8201815/webrev.00/
With this change, We switch from a home-grown public suffix list (implemented
in sun/net/RegisteredDomain.java) to Mozilla's PSL. The PSL data was re-encoded
as a zip file with entries for different TLDs.
There is
