Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread Magnus Ihse Bursie
Hi Jorn, As you probably have understood by now, porting OpenJDK to msys2 is not just a simple quick fix. If all you want is to build OpenJDK on your Windows computer, you are probably better off by trying to fix your Cygwin installation. From your description, it sounds like you'll need to r

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-11 22:42, Erik Joelsson wrote: Hello, Based on the discussion here, I have reverted back to something more similar to webrev.02, but with a few changes. Mainly fixing a bug that caused JVM_FEATURES_hardened to not actually be the same as for server (if you have custom additions

Re: RFR: JDK-8204602 Add devkit for linux-arm32

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-12 08:06, David Holmes wrote: On 11/06/2018 4:46 PM, Magnus Ihse Bursie wrote: On 2018-06-10 15:35, David Holmes wrote: On 8/06/2018 6:38 PM, Magnus Ihse Bursie wrote: With some simple changes, our devkit scripts can be made to generate devkits for cross-compiling on linux-x64 to

Re: RFR: JDK-8204602 Add devkit for linux-arm32

2018-06-11 Thread David Holmes
On 11/06/2018 4:46 PM, Magnus Ihse Bursie wrote: On 2018-06-10 15:35, David Holmes wrote: On 8/06/2018 6:38 PM, Magnus Ihse Bursie wrote: With some simple changes, our devkit scripts can be made to generate devkits for cross-compiling on linux-x64 to linux-arm (32-bit). Also add a jib profile

Re: [11] RFR(S) 8204113: Upgrade linker used in AOT tests to be same version as build toolchain

2018-06-11 Thread Igor Ignatev
Hi Vladimir, The fix looks good to me. — Igor > On Jun 11, 2018, at 6:15 PM, Vladimir Kozlov > wrote: > > http://cr.openjdk.java.net/~kvn/8204113/webrev.01/ > https://bugs.openjdk.java.net/browse/JDK-8204113 > > AOT tests need a local linker to generate AOT libraries. They load devkits > f

[11] RFR(S) 8204113: Upgrade linker used in AOT tests to be same version as build toolchain

2018-06-11 Thread Vladimir Kozlov
http://cr.openjdk.java.net/~kvn/8204113/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8204113 AOT tests need a local linker to generate AOT libraries. They load devkits from our infrastructure when there is no local linker on testing machine. The names of devkits are hardcoded in AotCompi

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread jesper . wilhelmsson
Looks good to me. /Jesper > On 11 Jun 2018, at 22:42, Erik Joelsson wrote: > > Hello, > > Based on the discussion here, I have reverted back to something more similar > to webrev.02, but with a few changes. Mainly fixing a bug that caused > JVM_FEATURES_hardened to not actually be the same as

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread jbvernee
Hello, I have tried the MSYS2_ARG_CONV_EXCL environment variable, thanks for the suggestion. It's supposed to be a semi-colon separated list of argument prefixes (they have some examples like `/switch;/sdcard;--root=`), so I tried setting it to `/out:`, `-Fe` (from the .m4 file) and `/out`, a

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread Erik Joelsson
Hello, Based on the discussion here, I have reverted back to something more similar to webrev.02, but with a few changes. Mainly fixing a bug that caused JVM_FEATURES_hardened to not actually be the same as for server (if you have custom additions in configure). I also added a check so that c

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread Erik Joelsson
Hello, On 2018-06-11 13:00, jbvernee wrote: Hello Erik, Thank you for the suggestion. Unfortunately it didn't help. TBH, I've been banging my head against trying to build the JDK on my machine on and off for a few months. So at this point I really appreciate any help that gets me even an inc

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread jbvernee
Hello Erik, Thank you for the suggestion. Unfortunately it didn't help. TBH, I've been banging my head against trying to build the JDK on my machine on and off for a few months. So at this point I really appreciate any help that gets me even an inch further, thanks. After your suggestion, I

Re: RFR: JDK-8204664 PrepareFailureLogs should be done after sequential make targets

2018-06-11 Thread Erik Joelsson
On 2018-06-11 11:09, Magnus Ihse Bursie wrote: On 2018-06-11 17:42, Erik Joelsson wrote: Hello, Looks ok. Perhaps this warrants a comment somewhere about the failure logs only working in parallel targets? Do you mean a comment in the code, or in the build documentation? I'm thinking in th

Re: RFR: JDK-8204664 PrepareFailureLogs should be done after sequential make targets

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-11 17:42, Erik Joelsson wrote: Hello, Looks ok. Perhaps this warrants a comment somewhere about the failure logs only working in parallel targets? Do you mean a comment in the code, or in the build documentation? /Magnus /Erik On 2018-06-11 01:50, Magnus Ihse Bursie wrote:

Re: bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread Erik Joelsson
Hello Jorn, I don't have access to an msys2 environment to try this myself and as we don't regularly build there, it's unfortunately not expected to work. Msys has a habit of trying to outsmart the user when treating paths, by automatically converting path formats from unix style to windows st

bash configure - LINK : fatal error LNK1104: cannot open file ...fixpath.exe

2018-06-11 Thread jbvernee
Hello, I've been trying to build the JDK using an msys2 toolchain, which seems to be possible according to this thread: http://mail.openjdk.java.net/pipermail/build-dev/2017-October/019862.html (although I'm not trying to use gcc, I'm using VS 15). I know it's advised to use cygwin, but I can

Re: RFR(XS): 8204684: [AIX] Build of libjli_static broken after change 8204572 (SetupJdkLibrary)

2018-06-11 Thread Volker Simonis
Hi Erik, Thomas, thanks for the quick review! Regards, Volker On Mon, Jun 11, 2018 at 5:59 PM, Thomas Stüfe wrote: > This looks good and I can confirm fixes our AIX build, > > Thanks for fixing! > > > ..Thomas > > > On Mon, Jun 11, 2018 at 4:48 PM, Volker Simonis > wrote: >> Hi, >> >> can I pl

Re: RFR(XS): 8204684: [AIX] Build of libjli_static broken after change 8204572 (SetupJdkLibrary)

2018-06-11 Thread Thomas Stüfe
This looks good and I can confirm fixes our AIX build, Thanks for fixing! ..Thomas On Mon, Jun 11, 2018 at 4:48 PM, Volker Simonis wrote: > Hi, > > can I please have a review for the following trivial build change > which fixes a build problem on AIX when building libjli_static: > > http://cr

Re: RFR(XS): 8204684: [AIX] Build of libjli_static broken after change 8204572 (SetupJdkLibrary)

2018-06-11 Thread Erik Joelsson
Looks ok. /Erik On 2018-06-11 07:48, Volker Simonis wrote: Hi, can I please have a review for the following trivial build change which fixes a build problem on AIX when building libjli_static: http://cr.openjdk.java.net/~simonis/webrevs/2018/8204684/ https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: JDK-8204682 Parsing for LOG=report=none is broken when combined with other keywords

2018-06-11 Thread Erik Joelsson
Looks good. Sneaky problem! /Erik On 2018-06-11 06:29, Magnus Ihse Bursie wrote: Parsing for LOG=report=none is broken when combined with other keywords, e.g. "LOG=info,report=none". Bug: https://bugs.openjdk.java.net/browse/JDK-8204682 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8204682-L

Re: RFR: JDK-8204127: Change bundle format on Windows to zip

2018-06-11 Thread Erik Joelsson
I agree, will change. /Erik On 2018-06-11 01:55, Magnus Ihse Bursie wrote: On 2018-06-09 02:05, Erik Joelsson wrote: The compressed archive bundles we create are all tar.gz format. On Windows that's not a very common format, requiring third party applications to handle, while the zip format

Re: RFR: JDK-8204664 PrepareFailureLogs should be done after sequential make targets

2018-06-11 Thread Erik Joelsson
Hello, Looks ok. Perhaps this warrants a comment somewhere about the failure logs only working in parallel targets? /Erik On 2018-06-11 01:50, Magnus Ihse Bursie wrote: When running a compound make line such as "make reconfigure clean jdk-image test-image", make will first single out the "s

RFR(XS): 8204684: [AIX] Build of libjli_static broken after change 8204572 (SetupJdkLibrary)

2018-06-11 Thread Volker Simonis
Hi, can I please have a review for the following trivial build change which fixes a build problem on AIX when building libjli_static: http://cr.openjdk.java.net/~simonis/webrevs/2018/8204684/ https://bugs.openjdk.java.net/browse/JDK-8204684 The reason is that change 8204572 forgot to add LIBJLI_

RFR: JDK-8204682 Parsing for LOG=report=none is broken when combined with other keywords

2018-06-11 Thread Magnus Ihse Bursie
Parsing for LOG=report=none is broken when combined with other keywords, e.g. "LOG=info,report=none". Bug: https://bugs.openjdk.java.net/browse/JDK-8204682 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8204682-LOG-report-parsing-broken/webrev.01 /Magnus

Re: RFR: JDK-8204127: Change bundle format on Windows to zip

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-09 02:05, Erik Joelsson wrote: The compressed archive bundles we create are all tar.gz format. On Windows that's not a very common format, requiring third party applications to handle, while the zip format can be natively extracted. This patch changes the bundle format for the JDK on

RFR: JDK-8204664 PrepareFailureLogs should be done after sequential make targets

2018-06-11 Thread Magnus Ihse Bursie
When running a compound make line such as "make reconfigure clean jdk-image test-image", make will first single out the "sequential" targets reconfigure and clean, and execute them single-threaded, in sequence, and then it will build the remaining targets in parallel. However, the macro Prepare

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread David Holmes
Sorry this is making my head spin. Doh! jvm-features only apply to the JVM. So I retract my last email - sorry. And with that I'm going to just bow out. You and Erik can figure it out. Thanks, David On 11/06/2018 6:19 PM, Magnus Ihse Bursie wrote: On 2018-06-11 09:38, David Holmes wrote: H

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-11 09:38, David Holmes wrote: Hi Magnus, On 11/06/2018 5:10 PM, Magnus Ihse Bursie wrote: On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be pri

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread David Holmes
Hi Magnus, On 11/06/2018 5:10 PM, Magnus Ihse Bursie wrote: On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-10 15:28, David Holmes wrote: On 9/06/2018 7:50 AM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread Magnus Ihse Bursie
On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggest