Re: RFR: JDK-8204973: Add build support for filtering translations

2018-06-13 Thread Daniel Fuchs
Hi Erik, The modifications to the logging test look good to me. Caveat: I don't speak chinese nor japanese ;-) cheers, -- daniel On 13/06/18 20:47, Erik Joelsson wrote: Hello, Oracle will reduce the number of languages that it maintains translations of JDK resources for. The current transla

RFR: JDK-8204973: Add build support for filtering translations

2018-06-13 Thread Erik Joelsson
Hello, Oracle will reduce the number of languages that it maintains translations of JDK resources for. The current translations will remain in the source for now, but we need a way to filter out a set of translations at build time so that we only include the ones we support. This patch adds s

Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

2018-06-13 Thread Thomas Stüfe
Thank you Magnus. On Wed, Jun 13, 2018 at 3:40 PM, Magnus Ihse Bursie wrote: > Looks good to me. > > /Magnus > >> 13 juni 2018 kl. 10:28 skrev Thomas Stüfe : >> >> Thank you Matthias! >> >> I'll wait for someone from the Oracle Build Group to have a say. >> >> ..Thomas >> >> On Wed, Jun 13, 2018

Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

2018-06-13 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 13 juni 2018 kl. 10:28 skrev Thomas Stüfe : > > Thank you Matthias! > > I'll wait for someone from the Oracle Build Group to have a say. > > ..Thomas > > On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias > wrote: >> Hi Thomas , thanks for fixing it, looks good

Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

2018-06-13 Thread Thomas Stüfe
Thank you Matthias! I'll wait for someone from the Oracle Build Group to have a say. ..Thomas On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias wrote: > Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . > > Best regards, Matthias > > > >> -Original Message- >> F

Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

2018-06-13 Thread Thomas Stüfe
Thank you Goetz! On Wed, Jun 13, 2018 at 8:54 AM, Lindenmaier, Goetz wrote: > Hi Thomas, > > thanks for fixing and doing the cleanup right away. > Looks good. > > Best regards, > Goetz. > >> -Original Message- >> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- >> boun...@openjdk.java.n

RE: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)

2018-06-13 Thread Baesken, Matthias
Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . Best regards, Matthias > -Original Message- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > Sent: Mittwoch, 13. Juni 2018 08:14 > To: build-dev ; ppc-aix-