Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

2018-06-18 Thread Volker Simonis
On Tue, Jun 19, 2018 at 6:54 AM, David Holmes wrote: > Hi Volker, > > v3 looks much cleaner - thanks. > > But AFAICS the change to jvmtiEnv.cpp is also not needed. > ClassLoaderExt::append_boot_classpath exists regardless of INCLUDE_CDS but > operates differently (just calling ClassLoader::add_to_

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

2018-06-18 Thread David Holmes
Hi Volker, v3 looks much cleaner - thanks. But AFAICS the change to jvmtiEnv.cpp is also not needed. ClassLoaderExt::append_boot_classpath exists regardless of INCLUDE_CDS but operates differently (just calling ClassLoader::add_to_boot_append_entries). Thanks, David On 19/06/2018 2:04 AM,

Re: JDK Build on Fedora 28

2018-06-18 Thread David Holmes
I've filed: https://bugs.openjdk.java.net/browse/JDK-8205201 for the underlying issue. Hotspot folk need to check if the warnings are legitmate or not. If not then we may need to disable this warning in the build. David On 19/06/2018 6:13 AM, Patrick Reinhart wrote: Hi Adrian, Thanks for

Re: RFR: 8205197: Never default to using libc++ on Linux

2018-06-18 Thread Tim Bell
Martin: 8205197: Never default to using libc++ on Linux http://cr.openjdk.java.net/~martin/webrevs/jdk/stlib-default/ https://bugs.openjdk.java.net/browse/JDK-8205197 Looks good. /Tim

RFR: 8205197: Never default to using libc++ on Linux

2018-06-18 Thread Martin Buchholz
8205197: Never default to using libc++ on Linux http://cr.openjdk.java.net/~martin/webrevs/jdk/stlib-default/ https://bugs.openjdk.java.net/browse/JDK-8205197

Re: RFR: JDK-8205183: Warning about using VS2017 should be removed

2018-06-18 Thread Tim Bell
Erik- Looks good to me as well. /Tim On 06/18/18 13:58, Phil Race wrote: +1 -phil. On 06/18/2018 01:34 PM, Erik Joelsson wrote: When using VS2017, configure prints a warning about the toolchain being unsupported. This needs to change now that this is the main toolchain version for OpenJDK o

Re: RFR: JDK-8205183: Warning about using VS2017 should be removed

2018-06-18 Thread Phil Race
+1 -phil. On 06/18/2018 01:34 PM, Erik Joelsson wrote: When using VS2017, configure prints a warning about the toolchain being unsupported. This needs to change now that this is the main toolchain version for OpenJDK on Windows (at least for Oracle). This patch removes the warning for VS2017

Re: RFR: JDK-8205055: Fix compilation optimization errors with new Solaris toolchain

2018-06-18 Thread Erik Joelsson
Hello, On 2018-06-15 05:44, Magnus Ihse Bursie wrote: On 2018-06-15 01:26, gary.ad...@oracle.com wrote: Locally tested the fix below and via mach5 jobs. The ~50 failed tests all completed successfully. It'd be good for Erik to repeat his full testing with this patch included in case it blocked

RFR: JDK-8205183: Warning about using VS2017 should be removed

2018-06-18 Thread Erik Joelsson
When using VS2017, configure prints a warning about the toolchain being unsupported. This needs to change now that this is the main toolchain version for OpenJDK on Windows (at least for Oracle). This patch removes the warning for VS2017 and adds it back for all other versions of Visual Studio

Re: JDK Build on Fedora 28

2018-06-18 Thread Patrick Reinhart
Hi Adrian, Thanks for the tip, worked flawlessly :-) -Patrick > Am 18.06.2018 um 22:02 schrieb John Paul Adrian Glaubitz > : > > Hi Patrick! > > Try building with “—disable-warnings-as-errors”, that should fix the problem. > > Adrian > > PS: Replying from mobile, excuse my brevity. > >> O

Re: JDK Build on Fedora 28

2018-06-18 Thread John Paul Adrian Glaubitz
Hi Patrick! Try building with “—disable-warnings-as-errors”, that should fix the problem. Adrian PS: Replying from mobile, excuse my brevity. > On Jun 18, 2018, at 9:36 PM, Patrick Reinhart wrote: > > Hi everybody, > > Can anyone give me some advice in what I should do in order to build the

JDK Build on Fedora 28

2018-06-18 Thread Patrick Reinhart
Hi everybody, Can anyone give me some advice in what I should do in order to build the OpenJDK on a Fedora 28? -Patrick At the moment I get those errors: Compiling 5 files for jdk.internal.vm.compiler.management /home/pr/sources/jdk/src/hotspot/os/posix/os_posix.cpp: In static member functi

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

2018-06-18 Thread Jiangli Zhou
Hi Volker, Thanks for adding CDS_ONLY to all FileMapInfo fields. It looks cleaner also with Thomas and David’s suggestion to remove the macros in globals.hpp and javaClasses.cpp. Thanks! Jiangli > On Jun 18, 2018, at 9:04 AM, Volker Simonis wrote: > > On Mon, Jun 18, 2018 at 8:17 AM, David H

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

2018-06-18 Thread Thomas Stüfe
Looks good to me, Volker. Thank you for fixing the tests. ..Thomas On Mon, Jun 18, 2018 at 6:04 PM, Volker Simonis wrote: > On Mon, Jun 18, 2018 at 8:17 AM, David Holmes wrote: >> Hi Volker, >> >> src/hotspot/share/runtime/globals.hpp >> >> This change should not be needed! We do minimal VM bui

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

2018-06-18 Thread Volker Simonis
On Mon, Jun 18, 2018 at 8:17 AM, David Holmes wrote: > Hi Volker, > > src/hotspot/share/runtime/globals.hpp > > This change should not be needed! We do minimal VM builds without CDS and we > don't have to touch the UseSharedSpaces defaults (unless recent change have > broken this - in which case t