Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hi David, On 6/25/2018 4:59 PM, David Holmes wrote: Hi Joe, Okay - no problem. Just looking for opportunities to streamline the process. Cheers, David I agree with the goal of striving for the a more streamlined process, but don't want to have to use it just yet ;-) -Joe

RFR: 8205616: Build fails with system headers after 8204572

2018-06-25 Thread John Paul Adrian Glaubitz
Hi! Please review this small change contributed by Fridrich Strba of SUSE and modified by Magnus which fixes the OpenJDK build when configuring to use system headers for libraries like jpeg and lcms. The bug report can be found in [1] and the webrev in [2]. Thanks, Adrian > [1]

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread David Holmes
Hi Joe, Okay - no problem. Just looking for opportunities to streamline the process. Cheers, David On 26/06/2018 9:42 AM, joe darcy wrote: Hi David, On 6/25/2018 4:13 PM, David Holmes wrote: Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hi David, On 6/25/2018 4:13 PM, David Holmes wrote: Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread Jonathan Gibbons
On 6/25/18 4:13 PM, David Holmes wrote: And should these be using --release instead of -source + -target? There might be a chicken-and-egg problem here, since --release needs to be appropriately updated as well.  -source and -target are simpler and more likely to be easy to update. --

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread David Holmes
Hi Joe, On 26/06/2018 4:10 AM, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12".

Re: Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread Erik Joelsson
Looks good to me. /Erik On 2018-06-25 14:09, mandy chung wrote: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release.  This patch replaces the hardcoded value with the value of a

Re: Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread Jonathan Gibbons
+1 -- Jon On 06/25/2018 02:09 PM, mandy chung wrote: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release. This patch replaces the hardcoded value with the value of a system property

Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread mandy chung
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release. This patch replaces the hardcoded value with the value of a system property "extlink.spec.version" passed to the javadoc at runtime.

Re: Python issues with defpath and jcheck

2018-06-25 Thread John Paul Adrian Glaubitz
Hi Erik! On 06/25/2018 08:38 PM, Erik Joelsson wrote: > I have a patch on review for fixing trees to work with Mercurial 4.6: > > http://mail.openjdk.java.net/pipermail/hg-tools-dev/2018-June/000236.html > > It looks like the defpath plugin is suffering similar problems. If you want > to fix

RFR: JDK-8205625: linux-aarch64-cmp-baseline fails builds-tier5

2018-06-25 Thread Erik Joelsson
The open part of this change adds debug versions of the *-cmp-baseline Jib profies. Webrev: http://cr.openjdk.java.net/~erikj/8205625/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8205625 /Erik

Re: RFR(M): 8205207: Port Graal unit tests under jtreg

2018-06-25 Thread Ekaterina Pavlova
Thanks Erik! -katya On 6/25/18 8:52 AM, Erik Joelsson wrote: Looks ok to me. /Erik On 2018-06-22 15:22, Ekaterina Pavlova wrote: Fixed and regenerated webrev at the same location:  http://cr.openjdk.java.net/~epavlova//8205207/webrev.01/index.html Erik, thanks again for your detailed

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-25 Thread Valerie Peng
Great, that's good then. Valerie On 6/22/2018 5:40 PM, Weijun Wang wrote: On Jun 23, 2018, at 8:35 AM, Valerie Peng wrote: On 6/22/2018 3:23 PM, Weijun Wang wrote: On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote: Max, Good catch on the SunRsaSign provider bug. Looking at the changes,

Re: Python issues with defpath and jcheck

2018-06-25 Thread Erik Joelsson
Hello John, I have a patch on review for fixing trees to work with Mercurial 4.6: http://mail.openjdk.java.net/pipermail/hg-tools-dev/2018-June/000236.html It looks like the defpath plugin is suffering similar problems. If you want to fix your local copy, Mercurial moved the method util.Abort

Python issues with defpath and jcheck

2018-06-25 Thread John Paul Adrian Glaubitz
Hi! I have tried to submit a patch to the submit repository today and was presented with a Python backtrace. I have already updated both "defpath" and "jcheck" to their latest version from Mercurual (trace below). Has anyone else seen this? glaubitz@z6:..incoming/submit> hg defpath -du glaubitz

JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-25 Thread joe darcy
Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12". This thread is to review the build-related portions

Re: [Fwd: Re: Build breakage with system jpeg and lcms and jdk-11+18]

2018-06-25 Thread John Paul Adrian Glaubitz
On 06/25/2018 04:35 PM, John Paul Adrian Glaubitz wrote: >> Adrian, any update on this? Is there a bug open? We need this fix for >> our future JDK 11 packages. > > Sorry, I was traveling over the weekend. I should be able to do it later > today. Bug report is: >

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

2018-06-25 Thread Jini George
Thank you, Erik ! - Jini. On 6/25/2018 9:23 PM, Erik Joelsson wrote: Build changes look good. /Erik On 2018-06-24 10:37, Jini George wrote: Hi Erik, Thank you very much for looking into this. I have addressed your comments. The latest webrev is at:

Re: Inquiry whether jdk8u can compile with icc?

2018-06-25 Thread Erik Joelsson
Hello, There is no support for ICC as far as I know. If ICC is compatible with the default toolchain for the platform, you may get something to work, but I doubt you will have any luck without modifying build logic. Which platform are you trying to build on? /Erik On 2018-06-25 08:19, Vic

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

2018-06-25 Thread Erik Joelsson
Build changes look good. /Erik On 2018-06-24 10:37, Jini George wrote: Hi Erik, Thank you very much for looking into this. I have addressed your comments. The latest webrev is at: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/ Thank you, Jini. On 6/23/2018 3:31 AM, Erik

Re: RFR(M): 8205207: Port Graal unit tests under jtreg

2018-06-25 Thread Erik Joelsson
Looks ok to me. /Erik On 2018-06-22 15:22, Ekaterina Pavlova wrote: Fixed and regenerated webrev at the same location:  http://cr.openjdk.java.net/~epavlova//8205207/webrev.01/index.html Erik, thanks again for your detailed reviews! -katya On 6/22/18 2:38 PM, Erik Joelsson wrote: Hello

Re: Inquiry whether jdk8u can compile with icc?

2018-06-25 Thread yumin qi
Hi, Vic You can try the help: sh configure --help Also export CC='your ICC' Yumin On Mon, Jun 25, 2018 at 8:20 AM Vic Wang(BJ-RD) wrote: > Hi, > >I get the openjdk-jdk8u-jdk8u source code, and I want to compile > jvm with ICC compiler. >How to configure jvm

Inquiry whether jdk8u can compile with icc?

2018-06-25 Thread Vic Wang(BJ-RD)
Hi, I get the openjdk-jdk8u-jdk8u source code, and I want to compile jvm with ICC compiler. How to configure jvm before using ICC compiling? If there are any tips for ICC compiling, please let me know. Thanks a lot. Best Regards! VicWang 保密声明:

Re: [Fwd: Re: Build breakage with system jpeg and lcms and jdk-11+18]

2018-06-25 Thread John Paul Adrian Glaubitz
Hi Severin! On 06/25/2018 04:12 PM, Severin Gehwolf wrote: >>> I'd propose: >>> >>> Contributed-by: Magnuse Ihse Bursie , >>> Fridrich Strba >> >> Perfect, thank you! > > Adrian, any update on this? Is there a bug open? We need this fix for > our future JDK 11 packages. Sorry, I was traveling

Re: [Fwd: Re: Build breakage with system jpeg and lcms and jdk-11+18]

2018-06-25 Thread Severin Gehwolf
On Fri, 2018-06-22 at 13:31 +0200, John Paul Adrian Glaubitz wrote: > Hi Severin! > > On 06/22/2018 01:19 PM, Severin Gehwolf wrote: > > > Now, before I create the bug report, do you happen to know which changeset > > > introduced the regression? We usually include that in the bug report. > > >

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

2018-06-25 Thread Jini George
Thank you, Sharath. May I have a Reviewer to take a look at the MacosxDebuggerLocal code? Thanks, Jini. On 6/25/2018 1:52 PM, Sharath Ballal wrote: Hi Jini, Changes in MacosxDebuggerLocal.m looks good. Thanks, Sharath -Original Message- From: Jini George Sent: Sunday, June 24,