Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

2018-06-26 Thread David Holmes
Hi Jini, I took a look ... that's about all I can say :) I know that you and Sharath have worked through this in detail over an extended period of time, so I'm okay to add my Reviewed stamp to it. About the only thing I'd suggest, if not already done, is to do a mach5 run only on OSX with --

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

2018-06-26 Thread Sundararajan Athijegannathan
Forgot to CC build-dev for makefile changes. -Sundar On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote: Please review. Bug https://bugs.openjdk.java.net/browse/JDK-8204492 Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01 Related: JEP http://openjdk.java.net/jeps/335 CSR htt

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread joe darcy
On 6/26/2018 10:11 AM, Paul Sandoz wrote: This generally looks good. Having it all consolidated helps a lot, and we are slowly chipping away at reducing this for each release. src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java — 118 V55(55, 0), // JDK 11: constan

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Paul Sandoz
This generally looks good. Having it all consolidated helps a lot, and we are slowly chipping away at reducing this for each release. src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java — 118 V55(55, 0), // JDK 11: constant dynamic 119 V56(56, 0); // JDK 1

Re: Inquiry whether jdk8u can compile with icc？

2018-06-26 Thread yumin qi
The first error is known issue and fixed in jdk 9: https://bugs.openjdk.java.net/browse/JDK-8016451 For the second one, I am not familiar with icc/icpc, it looks the linker find a static version which is not an expected version. you need to check the detail of library dependency. Yumin On Mon, J

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Erik Joelsson
Build changes look good. I'm happy at least those are very few at this point. To make the updating of "-source 12 -target 12" easier in the future, we could introduce another variable in version-numbers that is used for these flags in SetupJavaCompilers.gmk so we get the build changes down to

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread joe darcy
Hi Alan, On 6/26/2018 2:23 AM, Alan Bateman wrote: On 25/06/2018 19:10, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "S

Re: RFR(M): 8205207: Port Graal unit tests under jtreg

2018-06-26 Thread Ekaterina Pavlova
Hello Magnus, On 6/26/18 12:50 AM, Magnus Ihse Bursie wrote: 23 juni 2018 kl. 00:22 skrev Ekaterina Pavlova mailto:ekaterina.pavl...@oracle.com>>: Fixed and regenerated webrev at the same location: http://cr.openjdk.java.net/~epavlova//8205207/webrev.01/index.html Better, but not done yet.

Re: RFR: 8205616: Build fails with system headers after 8204572

2018-06-26 Thread Erik Joelsson
Correct. /Erik On 2018-06-26 07:35, John Paul Adrian Glaubitz wrote: Hi Erik! Thanks! I assume since this affects the build infrastructure only, one reviewer is enough, correct? Adrian On 06/26/2018 04:33 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-06-25 17:21, John Paul Adrian

Re: 答复: Inquiry whether jdk8u can compile with icc？

2018-06-26 Thread Erik Joelsson
Hello VicWang, The native source for Linux is written for GCC. Making it work with a different compiler is likely a lot of work that requires deep knowledge both in the JVM source and with the particular compiler. I have neither. Even if you got it to compile it's unlikely to work well since n

Re: RFR: 8205616: Build fails with system headers after 8204572

2018-06-26 Thread John Paul Adrian Glaubitz
Hi Erik! Thanks! I assume since this affects the build infrastructure only, one reviewer is enough, correct? Adrian On 06/26/2018 04:33 PM, Erik Joelsson wrote: > Looks good. > > /Erik > > > On 2018-06-25 17:21, John Paul Adrian Glaubitz wrote: >> Hi! >> >> Please review this small change co

Re: RFR: 8205616: Build fails with system headers after 8204572

2018-06-26 Thread Erik Joelsson
Looks good. /Erik On 2018-06-25 17:21, John Paul Adrian Glaubitz wrote: Hi! Please review this small change contributed by Fridrich Strba of SUSE and modified by Magnus which fixes the OpenJDK build when configuring to use system headers for libraries like jpeg and lcms. The bug report can b

Re: JDK 12 RFR of JDK-8205615: Start of release updates for JDK 12 / JDK-8205621: Increment JDK version for JDK 12

2018-06-26 Thread Alan Bateman
On 25/06/2018 19:10, joe darcy wrote: Hello, With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12". This thread is

Re: RFR(M): 8205207: Port Graal unit tests under jtreg

2018-06-26 Thread Magnus Ihse Bursie
> 23 juni 2018 kl. 00:22 skrev Ekaterina Pavlova : > > Fixed and regenerated webrev at the same location: > http://cr.openjdk.java.net/~epavlova//8205207/webrev.01/index.html Better, but not done yet. In JtregGraalUnit.gmk: line 52-53 should be on a single line. The SRC list for BUILD_VM_COMP

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

2018-06-26 Thread Jini George
Ping - Gentle reminder ! Thanks, Jini. On 6/25/2018 3:41 PM, Jini George wrote: Thank you, Sharath. May I have a Reviewer to take a look at the MacosxDebuggerLocal code? Thanks, Jini. On 6/25/2018 1:52 PM, Sharath Ballal wrote: Hi Jini, Changes in MacosxDebuggerLocal.m looks good. Thanks,