Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Igor Ignatyev
> On Jul 2, 2018, at 3:52 PM, Vladimir Kozlov > wrote: > > On 7/2/18 3:28 PM, Igor Ignatyev wrote: >> Vladimir, >> there are two different configure-time problems: >> - 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI >> - 2nd is not getting configure time warnings when

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Vladimir Kozlov
On 7/2/18 3:28 PM, Igor Ignatyev wrote: Vladimir, there are two different configure-time problems: - 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI - 2nd is not getting configure time warnings when Graal is enabled, but 3rd party libs aren't available for tests. AFAIU,

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Igor Ignatyev
Vladimir, there are two different configure-time problems: - 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI - 2nd is not getting configure time warnings when Graal is enabled, but 3rd party libs aren't available for tests. AFAIU, 8206135 is about 1st problem, and I, as

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Vladimir Kozlov
On 7/2/18 2:17 PM, David Holmes wrote: Hi Katya, On 3/07/2018 5:10 AM, Ekaterina Pavlova wrote: Hi All, please review this extra small change which makes make more silent by removing info message in case graal unit tests are not built. Happy to see the build-time warning go, but I thought

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread David Holmes
Hi Katya, On 3/07/2018 5:10 AM, Ekaterina Pavlova wrote: Hi All, please review this extra small change which makes make more silent by removing info message in case graal unit tests are not built. Happy to see the build-time warning go, but I thought it was going to be replaced by some kind

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Erik Joelsson
Looks good. /Erik On 2018-07-02 12:10, Ekaterina Pavlova wrote: Hi All, please review this extra small change which makes make more silent by removing info message in case graal unit tests are not built.     JBS: https://bugs.openjdk.java.net/browse/JDK-8206113  webrev:

Re: RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Vladimir Kozlov
Okay. Thanks, Vladimir On 7/2/18 12:10 PM, Ekaterina Pavlova wrote: Hi All, please review this extra small change which makes make more silent by removing info message in case graal unit tests are not built.     JBS: https://bugs.openjdk.java.net/browse/JDK-8206113  webrev:

RFR(XXS): 8206113: Troubles configuring graal tests

2018-07-02 Thread Ekaterina Pavlova
Hi All, please review this extra small change which makes make more silent by removing info message in case graal unit tests are not built. JBS: https://bugs.openjdk.java.net/browse/JDK-8206113 webrev: http://cr.openjdk.java.net/~epavlova//8206113/webrev.00/index.html thanks, -katya p.s.

Re: RFR: windows-x64-cmp-baseline fails with The files do not have the same suffix type

2018-07-02 Thread Tim Bell
Erik: The compare script seems to have gotten messed up regarding the sec-*bin.zip files, causing it to try to compare directories as zip files. This patch fixes the setting up of the variables related to those files. Bug: https://bugs.openjdk.java.net/browse/JDK-8206087 Webrev: