Re: [8u] RFR: 8206425: .gnu_debuglink sections added unconditionally when no debuginfo is stripped

2018-07-18 Thread Andrew Hughes
On 17 July 2018 at 14:57, Severin Gehwolf wrote: > Hi Andrew, > > On Sun, 2018-07-15 at 03:11 +0100, Andrew Hughes wrote: >> On 6 July 2018 at 09:26, Severin Gehwolf wrote: >> > Hi David, >> > >> > On Fri, 2018-07-06 at 11:53 +1000, David Holmes wrote: >> > > Hi Severin, >> > > >> > > On 6/07/201

adding additional numbers to the Java version string

2018-07-18 Thread Tony Printezis
Hi all, According to the Java version string spec (JEPs 223 and 322) the first part of the version string is a sequence of numbers separated by periods. The sequence can be of arbitrary length. However, in the OpenJDK configure scripts, the sequence length is fixed to exactly four numbers. For ou

Re: custom extension for make/SourceRevision.gmk

2018-07-18 Thread Christian Thalinger
> On Jul 18, 2018, at 1:46 PM, Erik Joelsson wrote: > > Hello Christian, > > Sometimes we need hooks both close to the beginning and close to the end of > the file, and in that case we create a SourceBundle-post.gmk. The recommended > position of the post inclusion is right before the typic

Re: custom extension for make/SourceRevision.gmk

2018-07-18 Thread Erik Joelsson
Hello Christian, Sometimes we need hooks both close to the beginning and close to the end of the file, and in that case we create a SourceBundle-post.gmk. The recommended position of the post inclusion is right before the typical "all: $(TARGETS)" declaration. This file has the all target depe

custom extension for make/SourceRevision.gmk

2018-07-18 Thread Christian Thalinger
Here at Twitter our OpenJDK clone lives in a GIT repository and we would like to use the source-revision feature of the release file. I have all the custom extension logic in place to create the revision tracker: $ cat build/macosx-x86_64-normal-server-release/support/src-rev/source-revision-tr

Re: [8u] RFR 8036003: Add --with-native-debug-symbols=[none|internal|external|zipped]

2018-07-18 Thread Severin Gehwolf
Hi Erik, On Wed, 2018-07-18 at 08:44 -0700, Erik Joelsson wrote: > Hello, > > Except for the left over debug printing $(info ...) line this looks good > to me. Thanks, Erik! webrev with info line removed: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8036003/webrev.03/ HG-export: http://cr

Re: [8u] RFR 8036003: Add --with-native-debug-symbols=[none|internal|external|zipped]

2018-07-18 Thread Erik Joelsson
Hello, Except for the left over debug printing $(info ...) line this looks good to me. /Erik On 2018-07-18 06:42, Severin Gehwolf wrote: Hi Erik, Latest webrev with default param over changes in the jdk tree: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8036003/webrev.02/ Thanks, Seve

Re: [8u] RFR 8036003: Add --with-native-debug-symbols=[none|internal|external|zipped]

2018-07-18 Thread Severin Gehwolf
Hi Erik, Latest webrev with default param over changes in the jdk tree: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8036003/webrev.02/ Thanks, Severin On Tue, 2018-07-17 at 09:16 -0700, Erik Joelsson wrote: > That should work, but if it doesn't, please try double dollar on > $(STRIP_POLIC