Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Michal Vala
Aha, this is for 11. It's ok then. On 07/24/2018 08:02 AM, Michal Vala wrote: Hi, On 07/23/2018 07:13 PM, Erik Joelsson wrote: The build documentation needs to be updated to reflect the compiler updates that took place at Oracle for JDK 11. Bug: https://bugs.openjdk.java.net/browse/JDK-82080

Re: RFR: JDK-8208084: Windows build failure - "'snprintf': identifier not found"

2018-07-23 Thread Michal Vala
On 07/23/2018 07:15 PM, Erik Joelsson wrote: Hello, On 2018-07-23 08:27, Kim Barrett wrote: On Jul 23, 2018, at 9:38 AM, Michal Vala wrote: Hi, JDK-8208084 introduced build failure on Windows, where `snprintf` function is not implemented by Visual Studio 2013 (currently latest compiler s

Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Michal Vala
Hi, On 07/23/2018 07:13 PM, Erik Joelsson wrote: The build documentation needs to be updated to reflect the compiler updates that took place at Oracle for JDK 11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208096 Webrev: http://cr.openjdk.java.net/~erikj/8208096/webrev.01/ /Erik OpenJ

Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Martin Buchholz
OHH ... thanks for the lesson. I'm disappointed by Apple's apparently deliberate version obfuscation. https://stackoverflow.com/questions/33603027/get-apple-clang-version-and-corresponding-upstream-llvm-version On Mon, Jul 23, 2018 at 10:51 AM, Erik Joelsson wrote: > That's what the compiler s

Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Erik Joelsson
That's what the compiler says: $ clang --version Apple LLVM version 9.1.0 (clang-902.0.39.2) Target: x86_64-apple-darwin17.6.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin I don't know how that version relates to the o

Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Tim Bell
Erik: The build documentation needs to be updated to reflect the compiler updates that took place at Oracle for JDK 11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208096 Webrev: http://cr.openjdk.java.net/~erikj/8208096/webrev.01/ Looks good. /Tim

Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Martin Buchholz
+ macOS Apple Xcode 9.4 (using clang 9.1.0) Is there really such a thing as clang 9.1.0, given that 6.0.1 is the latest from http://releases.llvm.org/ ? On Mon, Jul 23, 2018 at 10:13 AM, Erik Joelsson wrote: > The build documentation needs to be updated to reflect the compiler > up

Re: RFR: JDK-8208084: Windows build failure - "'snprintf': identifier not found"

2018-07-23 Thread Erik Joelsson
Hello, On 2018-07-23 08:27, Kim Barrett wrote: On Jul 23, 2018, at 9:38 AM, Michal Vala wrote: Hi, JDK-8208084 introduced build failure on Windows, where `snprintf` function is not implemented by Visual Studio 2013 (currently latest compiler supported by OpenJDK). I believe using `sprintf`

RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-23 Thread Erik Joelsson
The build documentation needs to be updated to reflect the compiler updates that took place at Oracle for JDK 11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208096 Webrev: http://cr.openjdk.java.net/~erikj/8208096/webrev.01/ /Erik

Re: RFF (12): JDK-8207954: Data for --release 11

2018-07-23 Thread Erik Joelsson
Hello Jan, The assignment of a non existent directory looks suspect. You should be able assign to an empty value using ?=. On the other hand, what it looks like you want to achieve is having both the open and closed value on the command line. Then I would just change the ?= to +=. /Erik On

Re: JDK 8 Build Issue(s)

2018-07-23 Thread Erik Joelsson
When you say "JDK 8", which repository did you clone? The recommendation is either of http://hg.openjdk.java.net/jdk8u/jdk8u or http://hg.openjdk.java.net/jdk8u/jdk8u-dev. The latter if you intend to do development. That's the source that is being updated and maintained with security patches. I

Re: Link Missing

2018-07-23 Thread Erik Joelsson
Right, the readme moved in JDK 9, thanks for pointing that out. Since jdk9 is no longer supported I will update that link to jdk/jdk. /Erik On 2018-07-21 08:16, mr rupplin wrote: I find the last link doesn't have a valid document attached to it. http://openjdk.java.net/groups/build/ Build In

Re: RFR: JDK-8208084: Windows build failure - "'snprintf': identifier not found"

2018-07-23 Thread Kim Barrett
> On Jul 23, 2018, at 9:38 AM, Michal Vala wrote: > > Hi, > > JDK-8208084 introduced build failure on Windows, where `snprintf` function is > not implemented by Visual Studio 2013 (currently latest compiler supported by > OpenJDK). > > I believe using `sprintf` is safe here. Please see the we

Re: JDK Memory Allocation

2018-07-23 Thread David Buck
Hi Max! Your question does not seem to be related to building OpenJDK, so I have BCCed build-dev from the thread and added gc-dev. That said, I am not sure any of the development lists are really an ideal place to ask general "code walk through" questions. If really necessary, memAllocator.c

Re: JDK Memory Allocation

2018-07-23 Thread Roger Riggs
Hi, Given the level of your questions, you will find it more rewarding to seek out and study presentations and articles about the structure of JVMs and their implementations. Regards, Roger On 7/21/18 7:51 PM, mr rupplin wrote: Having looked for some while at the OpenJDK source code I am un

RFR: JDK-8208084: Windows build failure - "'snprintf': identifier not found"

2018-07-23 Thread Michal Vala
Hi, JDK-8208084 introduced build failure on Windows, where `snprintf` function is not implemented by Visual Studio 2013 (currently latest compiler supported by OpenJDK). I believe using `sprintf` is safe here. Please see the webrev. If it's ok, I would also need a sponsor for this. bug: ht

RFF (12): JDK-8207954: Data for --release 11

2018-07-23 Thread Jan Lahoda
Hi, To support --release 11 in JDK 12, historical data for JDK 11 need to be added. As new attributes (NestHost and NestMembers) have been added to the classfile, there also needs to be some tweaking of the tool that creates the historical descriptions and the ct.sym sigfiles. The proposed p