Re: [PING] RFR(XS): 8208091: SA: jhsdb jstack --mixed throws UnmappedAddressException on i686

2018-08-07 Thread Chris Plummer
Hi Severin, The changes look fine. Thanks for adding the test case. Chris On 8/6/18 4:53 AM, Severin Gehwolf wrote: Hi, Latest webrev with JNI properly compiled with -fomit-frame-pointer and -O3. There was a bug in the test where the exception wasn't properly rethrown: http://cr.openjdk.java.

Re: RFR(S) 8205078: [Graal] org.graalvm.compiler.core.test.VerifyDebugUsageTest fails with "Expected exception: VerificationError"

2018-08-07 Thread Vladimir Kozlov
Okay. Changes are good then. Vladimir On 8/6/18 11:40 PM, Doug Simon wrote: On 7 Aug 2018, at 08:07, Ekaterina Pavlova wrote: Vladimir, thanks for prompt review. I can revert the changes and add -XDstringConcat=inline to JAVAC flags for all tests. I did it only for org/graalvm/compiler/c

Re: RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-07 Thread David Holmes
Hi Thomas, On 7/08/2018 7:34 PM, Thomas Schatzl wrote: Hi David, On Tue, 2018-08-07 at 07:17 +1000, David Holmes wrote: Hi Thomas, On 6/08/2018 10:38 PM, Thomas Schatzl wrote: Hi David, On Fri, 2018-08-03 at 10:20 +1000, David Holmes wrote: Hi Thomas, On 2/08/2018 7:14 PM, Thomas Schatzl

Re: RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-07 Thread Thomas Schatzl
Hi David, On Tue, 2018-08-07 at 07:17 +1000, David Holmes wrote: > Hi Thomas, > > On 6/08/2018 10:38 PM, Thomas Schatzl wrote: > > Hi David, > > > > On Fri, 2018-08-03 at 10:20 +1000, David Holmes wrote: > > > Hi Thomas, > > > > > > On 2/08/2018 7:14 PM, Thomas Schatzl wrote: > > > > Hi all, >