Re: [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

2018-10-18 Thread Phil Race
And +1 from me too. -phil. On 10/18/2018 01:30 PM, Magnus Ihse Bursie wrote: 18 okt. 2018 kl. 01:02 skrev Sergey Bylokhov : On 17/10/2018 13:59, Phil Race wrote: Everything in here - except the subject line - points to a completely unrelated bug + fix. I believe you meant : https://bugs.open

Re: [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

2018-10-18 Thread Magnus Ihse Bursie
> 18 okt. 2018 kl. 01:02 skrev Sergey Bylokhov : > >> On 17/10/2018 13:59, Phil Race wrote: >> Everything in here - except the subject line - points to a completely >> unrelated bug + fix. >> I believe you meant : >> https://bugs.openjdk.java.net/browse/JDK-8212213 >> http://cr.openjdk.java.net

Re: RFR: 8211879 : Broken links in API overview

2018-10-18 Thread Erik Joelsson
Looks good. /Erik On 2018-10-18 03:25, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8211879 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211879/webrev.00/ Thanks, Priya

Re: Build niceness

2018-10-18 Thread Erik Joelsson
Hello Aleksey, We very deliberately added the automatic niceness for a better general user experience. This was back when build-infra was new and we started pushing the parallelism of the build to where the UIs of our development systems became annoyingly slow and sluggish when building. So, I

Re: RFR: 8061281: Microbenchmark suite build support, directory layout and sample benchmarks

2018-10-18 Thread Erik Joelsson
Note that if the AOT support goes in first, we probably want to extend that support to running micros as well. /Erik On 2018-10-18 08:58, Erik Joelsson wrote: Looks good to me. /Erik On 2018-10-17 15:08, Claes Redestad wrote: Hi, added documentation of the new build targets, and synced up

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

2018-10-18 Thread Erik Joelsson
Hello, I think this looks good, but since I made most of the makefile changes, I would prefer if Magnus had a look through it too. /Erik On 2018-10-17 23:29, Ekaterina Pavlova wrote: Hi All, Please review the changes which add support to build AOTed jdk modules and then use them during th

Re: RFR: 8061281: Microbenchmark suite build support, directory layout and sample benchmarks

2018-10-18 Thread Erik Joelsson
Looks good to me. /Erik On 2018-10-17 15:08, Claes Redestad wrote: Hi, added documentation of the new build targets, and synced up with recent changes (thanks Erik for help dealing with some tricky merge conflicts): http://cr.openjdk.java.net/~redestad/8061281/jdk.01/ Thanks! /Claes On

Re: RFR: 8211879 : Broken links in API overview

2018-10-18 Thread Jonathan Gibbons
Looks OK to me. -- Jon On 10/18/18 3:25 AM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8211879 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211879/webrev.00/ Thanks, Priya

RFR: 8211879 : Broken links in API overview

2018-10-18 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8211879 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8211879/webrev.00/ Thanks, Priya

Build niceness

2018-10-18 Thread Aleksey Shipilev
Hi, Is there any specific user story behind "nice"-ing the compilation jobs from within the build system? It unfortunately clashes with priority budgeting. For example, my build server is used by me doing adhoc builds, automatic builds and some background tasks. The automatic build user has pr