Re: Stop using precompiled headers for Linux?

On 2018-11-02 15:00, Magnus Ihse Bursie wrote: So obviously this is a nice improvement even here. I could probably try around a bit and see if there is an even better fit with a different selections of header files, but even without that, I'd say this patch is by itself as good for clang as

Re: Stop using precompiled headers for Linux?

On 2018-11-02 17:21, Erik Joelsson wrote: Nice work! What exactly are you measuring, "make hotspot" or some other target? Yes, "make hotspot". If we can find a reasonable set of extra files for the windows pch that restores all or most of the performance, that would of course be preferable

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

> 2 nov. 2018 kl. 18:03 skrev Igor Ignatyev : > > Hi Magnus, > >> You still need to fix FindTests.gmk, though. > thanks for spotting that. is [*] enough, or did I miss something else? This looks enough. Thanks! /Magnus > > -- Igor > > [*] >> diff -r c6d128f60997 make/common/FindTests.gmk >

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Hi Magnus, > You still need to fix FindTests.gmk, though. thanks for spotting that. is [*] enough, or did I miss something else? -- Igor [*] > diff -r c6d128f60997 make/common/FindTests.gmk > --- a/make/common/FindTests.gmk Thu Nov 01 16:33:43 2018 -0700 > +++ b/make/common/FindTests.gmk Fri Nov

Re: Stop using precompiled headers for Linux?

On 11/02/2018 12:14 PM, Magnus Ihse Bursie wrote: > And here is the "winning" list (which I declared as "on or above 130, without > inline"). I encourage > everyone to try this on their own system, and report back the results! > > #ifndef DONT_USE_PRECOMPILED_HEADER > # include "classfile/classLo

Re: Stop using precompiled headers for Linux?

Nice work! What exactly are you measuring, "make hotspot" or some other target? If we can find a reasonable set of extra files for the windows pch that restores all or most of the performance, that would of course be preferable. I doubt we will find a significantly better selection on Mac com

Re: Stop using precompiled headers for Linux?

Hi Magnus, your winning variant gives me a nice boost on my thinkpad: pch, standard: real17m52.367s user52m20.730s sys 4m53.711s pch, your variant: real15m0.514s user46m6.466s sys 2m38.371s (non-pch is ~19-20 minutes WTC) With those numbers, I might start using pch agai

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

Hi Katya, Just FYI, non-tiered .so libs from java.base and Graal are compiled and linked on aarch64 as expected. I.e. like jaotc -J-Xmx4g --info --compile-with-assertions --output java.base.so --module java.base --compile-commands java.base-list.txt So it will be good to have this change fo

Re: Stop using precompiled headers for Linux?

On 2018-11-02 12:14, Magnus Ihse Bursie wrote: Caveats: I have only run this on my local linux build with the default server JVM configuration. Other machines will have different sweet spots. Other JVM variants/feature combinations will have different sweet spots. And, most importantly, I have

Re: Stop using precompiled headers for Linux?

On 2018-11-02 11:39, Magnus Ihse Bursie wrote: On 2018-11-02 00:53, Ioi Lam wrote: Maybe precompiled.hpp can be periodically (weekly?) updated by a robot, which parses the dependencies files generated by gcc, and pick the most popular N files? I think that's tricky to implement automatically.

Re: Stop using precompiled headers for Linux?

On 2018-11-02 00:53, Ioi Lam wrote: Maybe precompiled.hpp can be periodically (weekly?) updated by a robot, which parses the dependencies files generated by gcc, and pick the most popular N files? I think that's tricky to implement automatically. However, I've done more or less, that, and I've

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

On 2018-11-02 00:37, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides removing test_log, it a

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Hi Igor, On 2018-11-01 22:15, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html What release are you targeting? This does not look like a patch that can be applied to jdk/jdk, at least not after JDK-8210958. When removing the "hotspot-internal" test, ple

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

On 2018-11-02 05:32, Ekaterina Pavlova wrote: yes, it is at the same location:  http://cr.openjdk.java.net/~epavlova//8152988/webrev.01/ I see. In the future, please do not update webrevs "in place" (except perhaps for minor changes like a typo in a comment). This invalidates the history of t

RE: minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-context flag in HS build

Hi Magnus / Erik , thanks for explaning ! Best regards, Matthias > -Original Message- > From: Magnus Ihse Bursie > Sent: Donnerstag, 1. November 2018 11:36 > To: Baesken, Matthias ; Aleksey Shipilev > ; 'build-dev@openjdk.java.net' d...@openjdk.java.net> > Subject: Re: minimal gcc vers