Hi Erik,
I cannot comment on the fix, but thanks for doing this!
Best Regards, Thomas
On Tue, Nov 6, 2018 at 7:06 PM Erik Joelsson wrote:
>
> A recent discussion on build-dev brought out the need for jdk-submit to
> include a build with precompiled headers disabled. We currently have
> such bui
Erik:
A recent discussion on build-dev brought out the need for jdk-submit to
include a build with precompiled headers disabled. We currently have
such builds in builds-tier2, which is not part of jdk-submit. In tier2
now, we actually build all slowdebug builds without pch, which is
overkill on
LGTM.
/Magnus
> 6 nov. 2018 kl. 19:04 skrev Erik Joelsson :
>
> A recent discussion on build-dev brought out the need for jdk-submit to
> include a build with precompiled headers disabled. We currently have such
> builds in builds-tier2, which is not part of jdk-submit. In tier2 now, we
> ac
> On Nov 6, 2018, at 6:55 AM, Kim Barrett wrote:
>
>> On Nov 6, 2018, at 6:16 AM, Magnus Ihse Bursie
>> wrote:
>>
>> In JDK-8211073, an attempt was made to add -Wextra to hotspot. That patch
>> was not accepted at the time being, but it did dig out some bugs in the code.
>>
>> While we await
A recent discussion on build-dev brought out the need for jdk-submit to
include a build with precompiled headers disabled. We currently have
such builds in builds-tier2, which is not part of jdk-submit. In tier2
now, we actually build all slowdebug builds without pch, which is
overkill on platf
> On Nov 6, 2018, at 6:16 AM, Magnus Ihse Bursie
> wrote:
>
> In JDK-8211073, an attempt was made to add -Wextra to hotspot. That patch was
> not accepted at the time being, but it did dig out some bugs in the code.
>
> While we await JDK-8211073 to be included in the code base (so -Wextra is
In JDK-8211073, an attempt was made to add -Wextra to hotspot. That
patch was not accepted at the time being, but it did dig out some bugs
in the code.
While we await JDK-8211073 to be included in the code base (so -Wextra
is always on), we can at least fix the bugs it found in some copy
cons
On 06/11/2018 04:35, Priyanka Mangal wrote:
The Eclipse launcher is capable of loading the Java VM in the eclipse
process using the Java Native Interface Invocation API. The launcher
is still capable of starting the Java VM in a separate process the
same as previous version of Eclipse did. Wh
I now noticed that this was only sent to build-dev. This is not really a build
question. Cc:ing core-libs-dev.
/Magnus
> 5 nov. 2018 kl. 15:21 skrev Magnus Ihse Bursie
> :
>
> Hi,
>
> Fix looks good, but maybe we should have a regression test of GetJREPath()?
>
> /Magnus
>
>> 5 nov. 2018 k
