Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-22 Thread Franco Gastón Pellegrini
Using the same command as before, and then using make CONF=windows-x86-normal-client-fastdebug clean; make CONF=windows-x86-normal-client-fastdebug; I get warnings as error, and cannot compile. The output is (and I attached the logs): $ make CONF=windows-x86-normal-client-fastdebug; Building

Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-22 Thread Franco Gastón Pellegrini
yes, it was gcc, for some reason it get broken. I reinstall cygwin and reconfigure it, an now it works, thanks! El lun., 5 de nov. de 2018 a la(s) 07:00, Magnus Ihse Bursie ( magnus.ihse.bur...@oracle.com) escribió: > On 2018-11-04 06:16, Franco Gastón Pellegrini wrote: > > I used this command:

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-11-22 Thread Magnus Ihse Bursie
I think we are in complete agreement. What's missing is some expert opinion from serviceability-dev if there is any problem with changing the signature. I'd preferably have that. If no one knows, I'd say, change it, and see if we still pass the relevant tests, and if so, ship it. /Magnus >

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-11-22 Thread Alexey Ivanov
On 21/11/2018 12:16, Magnus Ihse Bursie wrote: On 2018-11-20 16:49, Alexey Ivanov wrote: Hi Ali, Magnus, I absolutely agree this change has to be reviewed by someone from serviceability. There are several options: 1. Add -export:jdwpTransport_OnLoad to LDFLAGS for Windows

Re: RFR(S): 8213698: Improve devkit creation and add support for linux/ppc64/ppc64le/s390x

2018-11-22 Thread Magnus Ihse Bursie
On 2018-11-22 11:27, Volker Simonis wrote: On Tue, Nov 20, 2018 at 1:46 PM Magnus Ihse Bursie wrote: Hi Volker, Glad to see you fix and clean up the devkit scripts! And you're more than welcome to add documentation to the building.md. OK, I've added a section about devkits to

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-22 Thread Alan Bateman
On 22/11/2018 10:54, Nick Gasson wrote: Have you looked at replacing the remaining usages of stat changed to stat64 instead? I've tried this just now and it also resolves the issue. I can test on some more platforms and update the webrev if this is the preferred solution? I'd say this is

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-22 Thread Nick Gasson
> >> Have you looked at replacing the remaining usages of stat changed to > >> stat64 instead? > > I've tried this just now and it also resolves the issue. I can > > test on some more platforms and update the webrev if this is the > > preferred solution? > I'd say this is preferred to adding

Re: RFR(S): 8213698: Improve devkit creation and add support for linux/ppc64/ppc64le/s390x

2018-11-22 Thread Volker Simonis
On Tue, Nov 20, 2018 at 1:46 PM Magnus Ihse Bursie wrote: > > Hi Volker, > > Glad to see you fix and clean up the devkit scripts! And you're more > than welcome to add documentation to the building.md. > OK, I've added a section about devkits to build.{md,html}. Please have a look and let me