Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-23 Thread David Holmes
On 23/11/2018 7:10 pm, Magnus Ihse Bursie wrote: On 2018-11-23 08:35, Franco Gastón Pellegrini wrote: Using the same command as before, and then using make CONF=windows-x86-normal-client-fastdebug clean; make CONF=windows-x86-normal-client-fastdebug; I get warnings as error, and cannot compile

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Alan Bateman
On 23/11/2018 11:13, Nick Gasson wrote: This looks right and reduces the stat usages in libjava down to one remaining case (ProcessHandlerImpl_linux.c). Hi Alan, Do you want me to do this one too for completeness? Although as it's calling stat() on the /proc/ directory I don't think it's possib

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Nick Gasson
> This looks right and reduces the stat usages in libjava down to one > remaining case (ProcessHandlerImpl_linux.c). Hi Alan, Do you want me to do this one too for completeness? Although as it's calling stat() on the /proc/ directory I don't think it's possible to hit the EOVERFLOW case. Thanks,

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Alan Bateman
On 23/11/2018 09:37, Nick Gasson wrote: Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.2/ This looks right and reduces the stat usages in libjava down to one remaining case (ProcessHandlerImpl_linux.c). I'm a bit unsure about #ifndef MACOSX - some existing f

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-23 Thread Nick Gasson
> Can you fix the stat usages in TimeZonone_md.c too? Hi Alan, I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.2/ I'm a bit unsure about #ifndef MACOSX - some existing files guard the stat64 #define with this (e.g. UnixFileSystem_md.c) and some don't (e.g. libnio/ch/FileDi

Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-23 Thread Magnus Ihse Bursie
On 2018-11-23 08:35, Franco Gastón Pellegrini wrote: Using the same command as before, and then using make CONF=windows-x86-normal-client-fastdebug clean; make CONF=windows-x86-normal-client-fastdebug; I get warnings as error, and cannot compile. The output is (and I attached the logs): $ m