Re: RFR: JDK-8217317 : Create jpackage native library for windows

2019-02-01 Thread Alexander Matveev
Hi Magnus, http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/ Moved files to libjpackage and remove JPACKAGELIB_SRC. Old wmain() was in jpackage.cpp line 461. Thanks, Alexander On 2/1/2019 3:39 AM, Magnus Ihse Bursie wrote: Hi Alexander, On 2019-02-01 05:22, Alexander Matveev wrote: P

Re: RFR: JDK-8218198: Revert devkit change in JDK-8217910 for linux-x64

2019-02-01 Thread Tim Bell
Erik: The devkit change for linux-x64 broke AOT testing. While a proper fix is worked on, we need to revert this change so normal testing past tier4 may proceed. The proper fix proved more difficult than expected. There is no need to back out the complete change. Only the usage of the new devki

RFR: JDK-8218198: Revert devkit change in JDK-8217910 for linux-x64

2019-02-01 Thread Erik Joelsson
The devkit change for linux-x64 broke AOT testing. While a proper fix is worked on, we need to revert this change so normal testing past tier4 may proceed. The proper fix proved more difficult than expected. There is no need to back out the complete change. Only the usage of the new devkit for

Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread Erik Joelsson
Looks good. /Erik On 2019-02-01 02:50, Magnus Ihse Bursie wrote: The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project. This patch aims to resolvi

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-02-01 Thread Andrew Leonard
Thanks for merging Magnus, Cheers Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Magnus Ihse Bursie To: Andrew Leonard Cc: David Holmes , build-dev@openjdk.

Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread naoto . sato
Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Naoto On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote: The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between th

Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-01 Thread David Holmes
Hi Matthias, On 1/02/2019 10:36 pm, Baesken, Matthias wrote: New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.1/ - adjusted globalDefinitions_xlc.hpp I don't think it makes sense to keep the comment which was obviously copied from the gcc file: // On Linux NULL is defin

RE: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-01 Thread Baesken, Matthias
New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.1/ - adjusted globalDefinitions_xlc.hpp - fixed some copyright years Best regards, Matthias > -Original Message- > From: Baesken, Matthias > Sent: Freitag, 1. Februar 2019 11:16 > To: 'David Holmes' ; 'hotspot- > d..

Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-01 Thread Magnus Ihse Bursie
On 2019-02-01 05:23, David Holmes wrote: Hi Matthias, On 1/02/2019 12:50 am, Baesken, Matthias wrote: Please review  this small webrev  . It contains a few changes  for  building hotspot   on AIX with xlclang++  / xlc16  . ( most likely switching to   xlclang++  / xlc16    will be a must on

Re: RFR: JDK-8217317 : Create jpackage native library for windows

2019-02-01 Thread Magnus Ihse Bursie
Hi Alexander, On 2019-02-01 05:22, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - jpackage launcher will now build same as Linux and OS X using SetupBuildLauncher. - jpa

RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread Magnus Ihse Bursie
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project. This patch aims to resolving most of this. The CLDRConverter build tool is now called from Ge

RE: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-01 Thread Baesken, Matthias
> > Confused. Which other xlc compilers set __GNUC_ as you are changing this > for all of them? Though to be honest I don't understand this whole > section anyway - we have a lengthy comment saying why you can't > necessarily assign NULL to an integer type and to use NULL_WORD instead > but then i

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-02-01 Thread Andrew Leonard
Thanks Magnus, no hurry, next week will be fine. Cheers Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Magnus Ihse Bursie To: Andrew Leonard Cc: Dav

RE: RFR : 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

2019-02-01 Thread Baesken, Matthias
Hi Magnus , yes IBM offers now in xlc 16.1 both the legacy xlc and additionally the xlclang++ . Sooner or later we have to switch to xlclang++ , because the legacy xlc will most likely not be able to support everything from “JEP 347: Adopt C++14 Language Features in HotSpot” .