On 2019-02-05 18:55, Erik Joelsson wrote:
On 2019-02-05 01:12, Magnus Ihse Bursie wrote:
On 2019-02-05 01:36, Erik Joelsson wrote:
Please review this fix for configure flags checking. The macros for
checking compiler capabilities were not able to handle cross
compilation very well. With th
On 2019-02-05 01:12, Magnus Ihse Bursie wrote:
On 2019-02-05 01:36, Erik Joelsson wrote:
Please review this fix for configure flags checking. The macros for
checking compiler capabilities were not able to handle cross
compilation very well. With this fix, they accept an optional PREFIX
argum
On 2019-02-05 18:01, Erik Joelsson wrote:
Looks good. I have read through all of them and it does not seem like
you got any wrong.
I note that you chose to express negatives as:
ifneq (isTargetFoo, true)
instead of:
ifeq (isTargetFoo, false)
I think I would have preferred the latter, giv
looks good, thanks for the adjustment!
Best regards,
Goetz.
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 5. Februar 2019 17:56
> To: Lindenmaier, Goetz ; David Holmes
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>; 'magnus.ihse.bur...@oracle.com'
>
> Cc:
Looks good. I have read through all of them and it does not seem like
you got any wrong.
I note that you chose to express negatives as:
ifneq (isTargetFoo, true)
instead of:
ifeq (isTargetFoo, false)
I think I would have preferred the latter, given that the new macros
return both true and f
Hi Götz, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.4/
> The old xlc stuff is good to be removed.
> Could you please remove USE_XLC_PREFETCH_WRITE_BUILTIN
> altogether and replace its only use by USE_XLC_BUILTINS?
>
Done .
> Also, I think it makes sense to put
> #if _
Thanks, Magnus. The change looks good to me too.
Naoto
On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote:
On 2019-02-01 14:43, naoto.s...@oracle.com wrote:
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same
as before this fix, correct?
Yes. I have verified this usi
On 2019-02-05 15:49, Magnus Ihse Bursie wrote:
To check for various aspects of the build or target platform, we do a
lot of checks like:
ifeq ($(OPENJDK_BUILD_OS_ENV), windows.cygwin)
...
The naming of those platform information variables is a bit
unfortunate. Yes, we know we're buil
Erik:
Looks good to me as well.
Tim
On 02/05/19 00:01, Magnus Ihse Bursie wrote:
On 2019-02-05 01:24, Erik Joelsson wrote:
This patch was a bit premature, but now with a proper fix in Jib, here
is an updated version. It restores the use of the new devkit as well
as changes some more instances
To check for various aspects of the build or target platform, we do a
lot of checks like:
ifeq ($(OPENJDK_BUILD_OS_ENV), windows.cygwin)
...
The naming of those platform information variables is a bit unfortunate.
Yes, we know we're building OpenJDK, so why the OPENJDK_ prefix? I've
On 2019-02-01 14:43, naoto.s...@oracle.com wrote:
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same
as before this fix, correct?
Yes. I have verified this using the COMPARE_BUILD functionality.
/Magnus
Naoto
On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
The
On 2019-02-05 01:36, Erik Joelsson wrote:
Please review this fix for configure flags checking. The macros for
checking compiler capabilities were not able to handle cross
compilation very well. With this fix, they accept an optional PREFIX
argument, instructing them to check the compiler with t
Hi Matthias,
The demangle fix is kind of preliminary, but to get the compiler
working it is acceptable to skip this code for now.
The old xlc stuff is good to be removed.
Could you please remove USE_XLC_PREFETCH_WRITE_BUILTIN
altogether and replace its only use by USE_XLC_BUILTINS?
Also, I thi
On 2019-02-01 23:38, Alexander Matveev wrote:
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/
Looks great, thank you!
I can't comment on the actual source code changes, so you'll need a
thumbs up from someone in core libs as well.
Moved files to libjpackage and remove JPA
On 2019-02-05 01:24, Erik Joelsson wrote:
This patch was a bit premature, but now with a proper fix in Jib, here
is an updated version. It restores the use of the new devkit as well
as changes some more instances of install_path to home_path.
Webrev: http://cr.openjdk.java.net/~erikj/8218177/w
15 matches
Mail list logo
