Re: RFR : 8218965: aix: support xlclang++ in the compiler detection

2019-02-14 Thread Magnus Ihse Bursie
On 2019-02-14 15:44, Baesken, Matthias wrote: Hello, please review this small change . On AIX, it adds detection of xlc16 / clangto the build environment. The xlc16 package contains 2 compiler frontends : * The legacy xlc * The new clang-based xlclang++ For older

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

2019-02-14 Thread Magnus Ihse Bursie
On 2019-02-15 04:31, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for WINDOWS, LINUX

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

2019-02-14 Thread Magnus Ihse Bursie
On 2019-02-15 00:26, Erik Joelsson wrote: Please review this minor fix. The JDK build now has support for generating man pages, and will try to do so if it finds pandoc on the system. Unfortunately, not all versions of pandoc are valid, and if a bad version is found, the build will fail. This p

RFR: JDK-8212091 : Move native code under platform specific folders and files

2019-02-14 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for WINDOWS, LINUX, MAC and POSIX. - MAC define is still used in Jav

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

2019-02-14 Thread Phil Race
Looks fine. I'll be happy to have this fix ! -phil. On 2/14/2019 3:26 PM, Erik Joelsson wrote: Please review this minor fix. The JDK build now has support for generating man pages, and will try to do so if it finds pandoc on the system. Unfortunately, not all versions of pandoc are valid, and

Re: RFR: JDK-8217032: Check pandoc capabilities in configure

2019-02-14 Thread Mikael Vidstedt
Looks good. Cheers, Mikael > On Feb 14, 2019, at 3:26 PM, Erik Joelsson wrote: > > Please review this minor fix. The JDK build now has support for generating > man pages, and will try to do so if it finds pandoc on the system. > Unfortunately, not all versions of pandoc are valid, and if a

RFR: JDK-8217032: Check pandoc capabilities in configure

2019-02-14 Thread Erik Joelsson
Please review this minor fix. The JDK build now has support for generating man pages, and will try to do so if it finds pandoc on the system. Unfortunately, not all versions of pandoc are valid, and if a bad version is found, the build will fail. This patch adds an extensions check for the foun

RFR : 8218965: aix: support xlclang++ in the compiler detection

2019-02-14 Thread Baesken, Matthias
Hello, please review this small change . On AIX, it adds detection of xlc16 / clangto the build environment. The xlc16 package contains 2 compiler frontends : * The legacy xlc * The new clang-based xlclang++ For older xlc (12 / 13) we should for now still support t

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-14 Thread Severin Gehwolf
On Wed, 2019-02-13 at 15:36 -0800, Mandy Chung wrote: > On 2/13/19 1:04 AM, Severin Gehwolf wrote: > > > --strip-native-debug-symbols no-keep-debuginfo > > --strip-native-debug-symbols strip-debuginfo > > --strip-native-debug-symbols remove-debuginfo > > > > It would avoid using negation. >