Re: RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

2019-03-07 Thread Alexander Matveev
Hi Erik, http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/ - Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and linking with libjava. Thanks, Alexander On 3/7/2019 6:52 AM, Erik Joelsson wrote: Hello Alexander, A few notes: $(call SET_SHARED_LIBRARY_ORIGIN) and TOOLCH

Re: RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

2019-03-07 Thread Erik Joelsson
Hello Alexander, A few notes: $(call SET_SHARED_LIBRARY_ORIGIN) and TOOLCHAIN_LINK_CXX have no effect on Windows, so should be removed to avoid confusion in the future. This new library does not link with libjava so I see no need to add that prerequisite declaration. /Erik On 2019-03-06 1