Re: RFR (S) 8074817: Resolve disabled warnings for libverify

Looks good to me, but someone from core libs should look at the source changes too. /Erik On 2019-03-08 09:35, Aleksey Shipilev wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8074817 Fix: http://cr.openjdk.java.net/~shade/8074817/webrev.03/ This hopefully resolves warnings in lib

RFR (S) 8074817: Resolve disabled warnings for libverify

Bug: https://bugs.openjdk.java.net/browse/JDK-8074817 Fix: http://cr.openjdk.java.net/~shade/8074817/webrev.03/ This hopefully resolves warnings in libverify. See bug report for warnings list. Testing: jdk-submit, local {Linux, Windows} x86_64 builds Thanks, -Aleksey

Re: RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

Build changes look good. /Erik On 2019-03-07 14:52, Alexander Matveev wrote: Hi Erik, http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/ - Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and linking with libjava. Thanks, Alexander On 3/7/2019 6:52 AM, Erik Joelsson wrot