Re: RFR: JDK-8220737: Jib based 32 bit windows builds fail

2019-03-15 Thread Tim Bell
Erik: My recent change for gcc8.2 changed the naming convention for devkits in jib-profiles.js (used for builds at Oracle). This messed up the rare occasions when we configure for a 32bit windows target. This patch fixes that situation specifically for windows 32/64 where we use the same devkit.

RFR: JDK-8220737: Jib based 32 bit windows builds fail

2019-03-15 Thread Erik Joelsson
My recent change for gcc8.2 changed the naming convention for devkits in jib-profiles.js (used for builds at Oracle). This messed up the rare occasions when we configure for a 32bit windows target. This patch fixes that situation specifically for windows 32/64 where we use the same devkit. Bug

Re: RFR: [8u] 8193764: Cannot set COMPANY_NAME when configuring a build

2019-03-15 Thread Martin Buchholz
Looks good to me. On Fri, Mar 15, 2019 at 12:05 PM Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8193764/webrev.01/ > > This one applies pretty much as-is, when adjustments are made to use the > jdk-option

RFR: [8u] 8193764: Cannot set COMPANY_NAME when configuring a build

2019-03-15 Thread Andrew John Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8193764/webrev.01/ This one applies pretty much as-is, when adjustments are made to use the jdk-options.m4 file rather than jdk-version.m4, which doesn't exist in 8u. generated-configure.sh i

Re: Fwd: [RFR] [8u] 8217753: Enable HotSpot builds on 5.x Linux kernels

2019-03-15 Thread Andrew John Hughes
On 14/03/2019 15:31, Erik Joelsson wrote: > Looks good to me. > > /Erik > > On 2019-03-13 17:27, Andrew John Hughes wrote: >> Forwarding to build-dev for wider review. >> >> Forwarded Message >> Subject: [RFR] 8217753: Enable HotSpot builds on 5.x Linux kernels >> Date: Mon, 11

Re: Fwd: [RFR] [8u] 8220397: JDK-8036003 backport regresses no_strip builds

2019-03-15 Thread Andrew John Hughes
On 14/03/2019 15:32, Erik Joelsson wrote: > Looks good. > > /Erik > > On 2019-03-13 17:27, Andrew John Hughes wrote: >> Forwarding to build-dev for wider review. >> >> Forwarded Message >> Subject: [RFR] 8220397: JDK-8036003 backport regresses no_strip builds >> Date: Mon, 11 Ma