RFR: 8220784: hsdis cannot be built with MinGW64

2019-03-18 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8220784 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.00/ I attempt to build hsdis for Windows on WSL Ubuntu 18.04 with gcc-mingw-w64-x86-64, but I saw error messages that some functions which

Re: RFR: [8u] 8193764: Cannot set COMPANY_NAME when configuring a build

2019-03-18 Thread Erik Joelsson
Looks good. /Erik On 2019-03-15 12:04, Andrew John Hughes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8193764/webrev.01/ This one applies pretty much as-is, when adjustments are made to use the jdk-options.m4 file rather tha

Re: RFR: [8u] 8193764: Cannot set COMPANY_NAME when configuring a build

2019-03-18 Thread Andrew Haley
On 3/15/19 7:04 PM, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8193764/webrev.01/ > > This one applies pretty much as-is, when adjustments are made to use the > jdk-options.m4 file rather than jdk-version

Re: RFR: [8u] 8193764: Cannot set COMPANY_NAME when configuring a build

2019-03-18 Thread Severin Gehwolf
On Fri, 2019-03-15 at 19:04 +, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8193764/webrev.01/ > > This one applies pretty much as-is, when adjustments are made to use the > jdk-options.m4 file rather t