Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Jing Tian
Thanks Erik ,Tim and David for your review ! Thanks Leslie for your help ! Jing Tian 在 2019/3/26 5:30, David Holmes 写道: Thanks Erik and Tim. Change pushed. David On 26/03/2019 1:57 am, Erik Joelsson wrote: Looks good. /Erik On 2019-03-24 23:29, David Holmes wrote: On 25/03/2019 4:23 pm,

[RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-25 Thread Andrew John Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8189761 Webrev(s): https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot/ https://cr.openjdk.java.net/~andrew/openjdk8/8189761/jdk/ https://cr.openjdk.java.net/~andrew/openjdk8/8189761/root/ This backport is largely clean, bar fuzzing, for the

Re: RFR(T): 8221434: Fix typo in lib-x11 autoconf error message about missing headers

2019-03-25 Thread Gustavo Romero
Hi David, On 03/25/2019 09:11 PM, David Holmes wrote: Looks good Gustavo. Thanks a lot for the quick review. Pushed to jdk/jdk since it's a trivial change. Best regards, Gustavo

Re: RFR(T): 8221434: Fix typo in lib-x11 autoconf error message about missing headers

2019-03-25 Thread David Holmes
Looks good Gustavo. Thanks, David On 26/03/2019 9:53 am, Gustavo Romero wrote: Hi, Could the following trivial change be reviewed, please? bug    : https://bugs.openjdk.java.net/browse/JDK-8221434 webrev : http://cr.openjdk.java.net/~gromero/8221434/v1/ Thank you and best regards, Gustavo

RFR(T): 8221434: Fix typo in lib-x11 autoconf error message about missing headers

2019-03-25 Thread Gustavo Romero
Hi, Could the following trivial change be reviewed, please? bug: https://bugs.openjdk.java.net/browse/JDK-8221434 webrev : http://cr.openjdk.java.net/~gromero/8221434/v1/ Thank you and best regards, Gustavo

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread David Holmes
Thanks Erik and Tim. Change pushed. David On 26/03/2019 1:57 am, Erik Joelsson wrote: Looks good. /Erik On 2019-03-24 23:29, David Holmes wrote: On 25/03/2019 4:23 pm, Jing Tian wrote: Hi David, Thanks for your review. Could you please sponsor it for me? Sure - once someone from the

Re: RFR: JDK-8221414: Bump required boot jdk version to 12

2019-03-25 Thread Tim Bell
Erik: Looks good to me as well. Tim On 03/25/19 13:03, Mikael Vidstedt wrote: Looks good. Cheers, Mikael On Mar 25, 2019, at 3:44 PM, Erik Joelsson wrote: With the release of JDK 12 it is now time to update the required boot jdk version for JDK 13 (to 12). This patch changes the

Re: RFR: JDK-8221414: Bump required boot jdk version to 12

2019-03-25 Thread Mikael Vidstedt
Looks good. Cheers, Mikael > On Mar 25, 2019, at 3:44 PM, Erik Joelsson wrote: > > With the release of JDK 12 it is now time to update the required boot jdk > version for JDK 13 (to 12). This patch changes the configure requirements as > well as bumps the version used for Jib builds at

RFR: JDK-8221414: Bump required boot jdk version to 12

2019-03-25 Thread Erik Joelsson
With the release of JDK 12 it is now time to update the required boot jdk version for JDK 13 (to 12). This patch changes the configure requirements as well as bumps the version used for Jib builds at Oracle. Bug: https://bugs.openjdk.java.net/browse/JDK-8221414 Webrev:

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Erik Joelsson
Looks good. /Erik On 2019-03-24 23:29, David Holmes wrote: On 25/03/2019 4:23 pm, Jing Tian wrote: Hi David, Thanks for your review. Could you please sponsor it for me? Sure - once someone from the build team also gives the okay. David Thanks a lot. Cheers, JingTian 在 2019/3/25

Re: Build OpenJDK 8 on MacOS Mojave (10.14.3)

2019-03-25 Thread Simon Tooke
I have successfully done this (with some very important caveats that make it useful only for hacking the JDK at this point). Please let me know if you have any comments or corrections to my rough guide: https://github.com/stooke/jdk8u-xcode10 I'll write a shell script at some point, and clean

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Tim Bell
David, JingTian, Leslie Zhai: On 25/03/2019 4:23 pm, Jing Tian wrote: Hi David, Thanks for your review. Could you please sponsor it for me? Sure - once someone from the build team also gives the okay. Looks good to me. Tim David Thanks a lot. Cheers, JingTian 在 2019/3/25 11:59,

RE: RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

2019-03-25 Thread Baesken, Matthias
Hi Christoph / Götz , thanks for the reviews ! Best Regards, Matthias > -Original Message- > From: Lindenmaier, Goetz > Sent: Freitag, 22. März 2019 11:08 > To: Langer, Christoph ; Baesken, Matthias > ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>;

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread David Holmes
On 25/03/2019 4:23 pm, Jing Tian wrote: Hi David, Thanks for your review. Could you please sponsor it for me? Sure - once someone from the build team also gives the okay. David Thanks a lot. Cheers, JingTian 在 2019/3/25 11:59, David Holmes 写道: Looks good to me! Thanks, David - On

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Jing Tian
Hi David, Thanks for your review. Could you please sponsor it for me? Thanks a lot. Cheers, JingTian 在 2019/3/25 11:59, David Holmes 写道: Looks good to me! Thanks, David - On 25/03/2019 1:41 pm, Leslie Zhai wrote: Hi David, Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/