Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-27 Thread Andrew John Hughes
On 26/03/2019 21:57, Langer, Christoph wrote: > Hi Andrew, > > thanks for doing this backport. I agree, Severin's finding needs to be added > to hotspot's Unix/Posix vm.make files. Yes, it was missed because it's already there prior to this patch in the 9 and up HotSpot build which is quite diff

Re: RFR: JDK-8220530: Build compare script does not compare the contents of the test image

2019-03-27 Thread Tim Bell
Erik: This patch adds comparison of the test image, if present in both build output directories. I also cleaned away comparing of some old Oracle closed images that no longer exist. Bug: https://bugs.openjdk.java.net/browse/JDK-8220530

Re: RFR: JDK-8205934: Define jdk -source/-target version in version-numbers file

2019-03-27 Thread Tim Bell
Erik: To make it easier to update the major version in the future, we should define a make variable for the -source/-target version number used when compiling jdk classes and have it be initiated through make/common/version-numbers, like all other version numbers. This patch does just that. Bug

RFR: JDK-8220530: Build compare script does not compare the contents of the test image

2019-03-27 Thread Erik Joelsson
This patch adds comparison of the test image, if present in both build output directories. I also cleaned away comparing of some old Oracle closed images that no longer exist. Bug: https://bugs.openjdk.java.net/browse/JDK-8220530 W

RFR: JDK-8205934: Define jdk -source/-target version in version-numbers file

2019-03-27 Thread Erik Joelsson
To make it easier to update the major version in the future, we should define a make variable for the -source/-target version number used when compiling jdk classes and have it be initiated through make/common/version-numbers, like all other version numbers. This patch does just that. Bug: ht