On 28/03/2019 09:30, Langer, Christoph wrote:
> Hi,
>
>>> Revised HotSpot webrev:
>>>
>>> https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02
>>
>> +++ new/src/share/vm/runtime/vm_version.cpp 2019-03-28
>> 03:52:51.384737947 +
>> @@ -140,7 +140,7 @@
>>
>> const char* Abstract_
Hi Erik and David,
Thanks for the review. I did a tier-1 run and all passed, so I pushed
the changes.
- Ioi
On 3/28/19 6:50 PM, David Holmes wrote:
+1
Thanks,
David
On 29/03/2019 6:20 am, Erik Joelsson wrote:
Looks good. Thanks for fixing this!
/Erik
On 2019-03-28 10:04, Ioi Lam wrote:
+1
Thanks,
David
On 29/03/2019 6:20 am, Erik Joelsson wrote:
Looks good. Thanks for fixing this!
/Erik
On 2019-03-28 10:04, Ioi Lam wrote:
https://bugs.openjdk.java.net/browse/JDK-8221621
The function FindJtregGroupsBody needs to filter out lines that starts
with "#".
==
On 28/03/2019 08:51, Severin Gehwolf wrote:
> On Thu, 2019-03-28 at 03:56 +, Andrew John Hughes wrote:
>> On 26/03/2019 21:57, Langer, Christoph wrote:
>>> Hi Andrew,
>>>
>>> thanks for doing this backport. I agree, Severin's finding needs to be
>>> added to hotspot's Unix/Posix vm.make fil
Looks good. Thanks for fixing this!
/Erik
On 2019-03-28 10:04, Ioi Lam wrote:
https://bugs.openjdk.java.net/browse/JDK-8221621
The function FindJtregGroupsBody needs to filter out lines that starts
with "#".
==
diff -r 7d5a4a48e876 make/common/FindTests.gmk
--- a/make/common
On 28/03/2019 17:15, Philip Race wrote:
> I've run SplashScreen jtreg tests, all tests pass.
I assume you mean you did this for 32 AND 64 bit builds ?
Yes, I ran the tests for both 32 and 64 bit builds.
--
Alexey
If so, then +1
-phil.
On 3/28/19, 9:11 AM, Alexey Ivanov wrote:
Any volunt
Looks fine.
Cheers, Thomas
On Thu, Mar 28, 2019 at 5:11 PM Alexey Ivanov
wrote:
> Any volunteers for review?
>
> On 24/03/2019 19:18, Alexey Ivanov wrote:
> > Hi,
> >
> > Please review the fix for jdk 13.
> >
> > bug: https://bugs.openjdk.java.net/browse/JDK-8217707
> > webrev: http://cr.openjd
> I've run SplashScreen jtreg tests, all tests pass.
I assume you mean you did this for 32 AND 64 bit builds ?
If so, then +1
-phil.
On 3/28/19, 9:11 AM, Alexey Ivanov wrote:
Any volunteers for review?
On 24/03/2019 19:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: ht
https://bugs.openjdk.java.net/browse/JDK-8221621
The function FindJtregGroupsBody needs to filter out lines that starts
with "#".
==
diff -r 7d5a4a48e876 make/common/FindTests.gmk
--- a/make/common/FindTests.gmk Wed Mar 27 14:40:36 2019 -0700
+++ b/make/common/FindTests.gmk
Any volunteers for review?
On 24/03/2019 19:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows.
On Thu, Mar 28, 2019 at 4:55 AM Alan Bateman
wrote:
> I'm curious who these "stakeholders" are and what they use these JRE
> bundle for? As you know, moving to a modular platform has blurred the
> historical distinction between what we knew as the JRE and JDK in the
> past. Are they concerned abo
Hello,
On 2019-03-28 04:47, Zeller, Arno wrote:
Hi Christoph,
thanks for the patch. Just one small suggestion – I think you could
use the same extension for jdk archive also for the jre archive in
make/autoconf/spec.gmk.in?
Something like this:
JRE_BUNDLE_NAME :=
jre-$(BASE_NAME)_bin$(DE
On 28/03/2019 09:07, Langer, Christoph wrote:
Hi build-dev,
today I’m coming up with kind of a backward oriented suggestion… don’t know how
well that would be received. Let’s see.
For JDK 11, with JDK-8200132 [0], the JRE build has been moved to legacy.
There has been some discussion beforehan
Hi Christoph,
thanks for the patch. Just one small suggestion – I think you could use the
same extension for jdk archive also for the jre archive in
make/autoconf/spec.gmk.in?
Something like this:
JRE_BUNDLE_NAME := jre-$(BASE_NAME)_bin$(DEBUG_PART). $(JDK_BUNDLE_EXTENSION)
Otherwise you will
Hi,
> > Revised HotSpot webrev:
> >
> > https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02
>
> +++ new/src/share/vm/runtime/vm_version.cpp 2019-03-28
> 03:52:51.384737947 +
> @@ -140,7 +140,7 @@
>
> const char* Abstract_VM_Version::vm_vendor() {
> #ifdef VENDOR
> - return X
Hi build-dev,
today I’m coming up with kind of a backward oriented suggestion… don’t know how
well that would be received. Let’s see.
For JDK 11, with JDK-8200132 [0], the JRE build has been moved to legacy.
There has been some discussion beforehand whether the JRE build can completely
be dropp
On Thu, 2019-03-28 at 03:56 +, Andrew John Hughes wrote:
> On 26/03/2019 21:57, Langer, Christoph wrote:
> > Hi Andrew,
> >
> > thanks for doing this backport. I agree, Severin's finding needs to be
> > added to hotspot's Unix/Posix vm.make files.
>
> Yes, it was missed because it's already
17 matches
Mail list logo
