Hi Erik,
Thank you for your review.
Hello Jie,
I think this kind of information would fit better under its own new
heading to make it more explicit. Then we could continue filling in
other similar notes for other tests there. At the bottom, something like:
## Notes for Specific Tests
###
Hi Erik,
On 4/04/2019 1:33 am, Erik Joelsson wrote:
Hello Jie,
This issue applies not only to --with-jmh, but to any configure
parameter given with a relative path. I think the proper fix would be to
record the current working directory when configure is launched and cd
to that directory
> On Apr 3, 2019, at 9:51 AM, Erik Joelsson wrote:
> On 2019-04-02 16:02, Kim Barrett wrote:
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221851
>>>
>>> Webrev: http://cr.openjdk.java.net/~erikj/8221851/webrev.01/index.html
>>>
>>> /Erik
>> Here's an alternative approach that seems
Even better. Looks good.
Tim
On 04/03/19 14:20, Erik Joelsson wrote:
I discovered in issue with this patch. If the build is run in a very
long directory path, the cat command line for combining the *.d files
can get too long and hit the command line limit. I've fixed this by
CDing into the
Hello Christoph,
Looking closer at what we are doing, we are actually overriding
JDK_RC_PLATFORM_NAME as well, and there are a couple of direct
references to that variable in our custom makefiles. So I will still
need to update those if this goes in.
In OpenJDK builds, the current strings
Hi Erik,
please see this new webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8221880.1/
I would now add a new configure flag --with-jdk-rc-name. By default, it is
unset and JDK_RC_NAME would be set to $PRODUCT_NAME $JDK_RC_PLATFORM_NAME. I
think this change would not create the need for
I discovered in issue with this patch. If the build is run in a very
long directory path, the cat command line for combining the *.d files
can get too long and hit the command line limit. I've fixed this by
CDing into the directory and listing the files with a relative path instead.
I also
Erik:
The Init.gmk and InitSupport.gmk makefiles provide the foundational
framework for bootstrapping the build. That bootstrap process has grown
over time and is starting to take significant time to execute on
Windows. One reason for this is that every extra command executed at
this level gets
On 4/3/19 7:13 PM, Roman Kennke wrote:
> Updated webrevs:
> Incremental:
> http://cr.openjdk.java.net/~rkennke/JDK-8221766/webrev.01.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/JDK-8221766/webrev.01/
Shenandoah parts look good.
-Aleksey
Good (C2 part).
Thanks,
Vladimir
On 4/3/19 10:13 AM, Roman Kennke wrote:
I don't think it should be part of this cleanup.
Fair enough.
I have run several tests today, and removing the is_Phi() call doesn't seem to
negatively impact Shenandoah.
Updated webrevs:
Incremental:
I don't think it should be part of this cleanup.
Fair enough.
I have run several tests today, and removing the is_Phi() call doesn't
seem to negatively impact Shenandoah.
Updated webrevs:
Incremental:
http://cr.openjdk.java.net/~rkennke/JDK-8221766/webrev.01.diff/
Full:
I don't think it should be part of this cleanup.
Please, file separate RFE to push this change with separate review and testing.
Thanks,
Vladimir
On 4/3/19 4:18 AM, Roland Westrelin wrote:
Hi Vladimir,
opto/loopnode.cpp new is_Phi check was added. Please, explain.
When we expand
Hello Jie,
This issue applies not only to --with-jmh, but to any configure
parameter given with a relative path. I think the proper fix would be to
record the current working directory when configure is launched and cd
to that directory when running reconfigure. Here is my suggested patch:
Looks good.
/Erik
On 2019-04-03 07:51, Langer, Christoph wrote:
Hi,
I'd like to backport the resurrection of the legacy JRE bundle target to jdk11
updates because it would help a lot in our build infrastructure. Maybe other
downstream vendors can take profit of this, too.
The patch doesn't
Hi,
I'd like to backport the resurrection of the legacy JRE bundle target to jdk11
updates because it would help a lot in our build infrastructure. Maybe other
downstream vendors can take profit of this, too.
The patch doesn't apply cleanly, so I had to resolve a bit. Please review my
Hello Christoph,
I understand your problem, but a complicating factor here is that the
version-numbers file is currently formatted as a properties file and we
do consume it as such in other places. While we don't specifically look
for this property there, I think it sets a bad precedent if we
Hello Jie,
I think this kind of information would fit better under its own new
heading to make it more explicit. Then we could continue filling in
other similar notes for other tests there. At the bottom, something like:
## Notes for Specific Tests
### Docker Tests
What do you think?
Hello Kim,
On 2019-04-02 16:02, Kim Barrett wrote:
On Apr 2, 2019, at 5:39 PM, Erik Joelsson wrote:
In JDK-8204551, exceptions.hpp started using THIS_FILE instead of __FILE__ to
generate exception messages. This is causing the precompiled header to no
longer provide any benefit on
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8221907
For more info (e.g. the symptom & how to reproduce), please see the JBS.
It can be fixed by
-
diff -r 3326be37cd9a make/autoconf/lib-tests.m4
--- a/make/autoconf/lib-tests.m4 Tue Apr 02
Hi Vladimir,
> opto/loopnode.cpp new is_Phi check was added. Please, explain.
When we expand barriers, if we find a null check nearby we move the
barrier close to the null check so there's a better chance of converting
it to an implicit null check. That happens as part of a pass of loop
opts.
Hi,
In our downstream build, I'd like to be able to set/customize the value for the
Windows RC properties "ProductName" and "FileDescription" via the
version-numbers file. These values manifest in Windows executable properties.
During the build ProductName gets set to "OpenJDK Platform 13" and
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8221894
Webrev: http://cr.openjdk.java.net/~jiefu/8221894/webrev.00/
This is a follow on from 8221342 to add comments for docker tests.
The docker tests with default parameters may fail on the os newer than
oraclelinux 7.6.
For
22 matches
Mail list logo
