http://cr.openjdk.java.net/~iignatyev//8222414/webrev.01
> 21638 lines changed: 21628 ins; 0 del; 10 mod;
Hi all,
could you please review this patch which makes mocking framework from google
test available for hotspot tests?
JBS: https://bugs.openjdk.java.net/browse/JDK-8222414
testing: tier1
w
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
Naoto
On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the newer MakeTargetDir macro instead. It
doesn't take an argument.
Otherwise build changes look good.
/Erik
On 2019-05-22 15:56, naoto.s...@oracle.com wrote:
Adding build-dev
Adding build-dev, as the change adds a small build tool to parse emoji-data.
Naoto
On 5/22/19 3:26 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8221431
The proposed CSR and changeset are located at:
https://b
Hi Erik,
On 2019-05-22 22:38, Erik Joelsson wrote:
This patch adds running of the Indify tool on the microbenchmark classes
after building them. The Indify tool is already present in the repo in
the java/lang/invoke test sources, so I'm building it from there.
Claes, could you take this for s
This patch adds running of the Indify tool on the microbenchmark classes
after building them. The Indify tool is already present in the repo in
the java/lang/invoke test sources, so I'm building it from there.
Claes, could you take this for spin and see that it works as expected?
Bug: https://
Hi,
Could I please get reviews for this minimal implementation of a tier1-
like test set for JDK 8u? The implementation is rather barebones as I
don't think it's worth rewriting the build system just for a command
that runs a certain set of tests across a select set of repositories.
I've re-used e
