Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-24 Thread Alan Bateman
On 25/05/2019 06:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this information was provided in

RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-24 Thread David Holmes
Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this information was provided in localised format by the launcher. The Xus

Re: [OpenJDK 2D-Dev] RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

2019-05-24 Thread Philip Race
No other comments so far so here's that update : http://cr.openjdk.java.net/~prr/8224778.1/ -phil. On 5/24/19, 2:41 PM, Philip Race wrote: Yes, I just copied that line + edited it. I can update both lines if that is what you are asking but I'll wait a little to see if there are any other comm

Re: RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

2019-05-24 Thread Philip Race
Yes, I just copied that line + edited it. I can update both lines if that is what you are asking but I'll wait a little to see if there are any other comments first. -phil. On 5/24/19, 2:16 PM, Erik Joelsson wrote: Hello Phil, Patch looks good, but the curly braces look weird in a makefile.

Re: RFR(L/XS) : 8222414 : bring googlemock v1.8.1

2019-05-24 Thread Igor Ignatyev
@Erik, Thanks! @hotspot (looking at Robin), can I get another review? -- Igor > On May 24, 2019, at 8:28 AM, Erik Joelsson wrote: > > Thanks, looks good! > > /Erik > > On 2019-05-23 19:07, Igor Ignatyev wrote: >> Hi Erik, >> >> thanks for your review. I've updated CompileGtest.gmk as you a

Re: RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

2019-05-24 Thread Erik Joelsson
Hello Phil, Patch looks good, but the curly braces look weird in a makefile. I see the line below which you probably emulated also uses them, but they really should just be normal braces. /Erik On 2019-05-24 14:03, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8224778 webre

RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

2019-05-24 Thread Phil Race
bug: https://bugs.openjdk.java.net/browse/JDK-8224778 webrev : http://cr.openjdk.java.net/~prr/8224778/ With this fix the test can find the demo jar in its traditional place as before, and now also where it is placed by JIB to be invoked from RunTests.gmk -phil

Re: Building OpenJDK 1.8 on Solaris SPARC 10 fails with compiler error

2019-05-24 Thread Martijn Verburg
Hi Matthias, We're building Solaris builds from the same source over at https://adoptopenjdk.net - feel free to use those binaries ( https://adoptopenjdk.net/releases.html#sparcv9_solaris) and/or our build scripts (github.com/adoptopenjdk/openjdk-build). When there are genuine upstream fixes to t

Re: testing a openjdk8u212-b03 on Solaris SPARC 10

2019-05-24 Thread Erik Joelsson
Hello Matthias, On 2019-05-24 05:14, Matthias Apitz wrote: El día viernes, mayo 24, 2019 a las 11:55:09a. m. +0200, Matthias Apitz escribió: I tried to use the JT regression test tool jtreg-4.2-b14.tar.gz the following way (as explained in its docs: http://openjdk.java.net/jtreg/runtests.html

Re: RFR(L/XS) : 8222414 : bring googlemock v1.8.1

2019-05-24 Thread Erik Joelsson
Thanks, looks good! /Erik On 2019-05-23 19:07, Igor Ignatyev wrote: Hi Erik, thanks for your review. I've updated CompileGtest.gmk as you advised[1], which gives [2]. -- Igor [1] diff -r 3443e083223d make/hotspot/lib/CompileGtest.gmk --- a/make/hotspot/lib/CompileGtest.gmk Thu May 23 19:03

Re: testing a openjdk8u212-b03 on Solaris SPARC 10

2019-05-24 Thread Matthias Apitz
El día viernes, mayo 24, 2019 a las 11:55:09a. m. +0200, Matthias Apitz escribió: > I tried to use the JT regression test tool jtreg-4.2-b14.tar.gz the > following way (as explained in its docs: > http://openjdk.java.net/jtreg/runtests.html > > > $ export JT_HOME=/export/home/sisis/guru/jt

testing a openjdk8u212-b03 on Solaris SPARC 10

2019-05-24 Thread Matthias Apitz
After the hints from David (thanks!) we restarted the building of openjdk8u212-b03 the correct way with Get the latest required software: 1. latest OpenJDK release source (aktually openjdk8u212-b03.tar.gz) 2. Solaris' Studio version 12.3 (note 12.6 will not work) 3. the JT regression test tool