Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread David Holmes
On 11/06/2019 12:11 pm, Oracle wrote: But you should see the date on the same line as the alias and the type. Ah I see. I was looking at the output from an old version of cacerts that shows things like: verisignclass2g2ca [jdk], Jun 12, 2018, trustedCertEntry, ... digicertassuredidg3 [jdk],

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread Oracle
But you should see the date on the same line as the alias and the type.  —Max 获取 Outlook for iOS On Tue, Jun 11, 2019 at 10:09 AM +0800, "David Holmes" wrote: Hi Max, On 11/06/2019 11:05 am, Weijun Wang wrote: > keytool -keystore ..

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread David Holmes
Hi Max, On 11/06/2019 11:05 am, Weijun Wang wrote: keytool -keystore .. -storepass changeit -list -rfc | grep -v "Creation date" would exclude the date (which has its own line). I don't see any "Creation Date" entry when I run the tool: > ./build/linux-x64-debug/images/jdk/bin/keytool -list

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread Weijun Wang
keytool -keystore .. -storepass changeit -list -rfc | grep -v "Creation date" would exclude the date (which has its own line). --Max > On Jun 11, 2019, at 8:39 AM, Weijun Wang wrote: > > The "keytool -list" output contains a creation data (I know it's useless > now), so if THIS_FILE and THAT_

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread Weijun Wang
The "keytool -list" output contains a creation data (I know it's useless now), so if THIS_FILE and THAT_FILE happen to be created on different dates then you will see difference. --Max > On Jun 11, 2019, at 7:37 AM, Erik Joelsson wrote: > > > On 2019-06-10 16:23, David Holmes wrote: >> Hi Er

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-10 Thread Nico Williams
On Mon, Jun 10, 2019 at 10:30:50AM +0800, Weijun Wang wrote: > Updated webrev at > >http://cr.openjdk.java.net/~weijun/6722928/webrev.08/ - src/java.security.jgss/share/classes/sun/security/jgss/spnego/NegTokenTarg.java Ugh, I never noticed GSSUtil.useMSInterop(). This really should no

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-10 Thread Weijun Wang
> On Jun 11, 2019, at 12:15 AM, Erik Joelsson wrote: > > Hello Max, > > I believe $(call FindSrcDirsForLib, $(MODULE), sspi_bridge) for SRC is the > default so you shouldn't need to specify it explicitly, or did you experience > some problems with the default that I'm missing? I don't reme

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread Erik Joelsson
On 2019-06-10 16:23, David Holmes wrote: Hi Erik, On 11/06/2019 5:37 am, Erik Joelsson wrote: Since JDK-8193255, when we started generating the cacerts file in the build, the build compare baseline builds have started failing. It seems the cacerts binary file has some non determinism built i

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread David Holmes
Hi Erik, On 11/06/2019 5:37 am, Erik Joelsson wrote: Since JDK-8193255, when we started generating the cacerts file in the build, the build compare baseline builds have started failing. It seems the cacerts binary file has some non determinism built in so it doesn't get generated exactly the s

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-10 Thread Valerie Peng
Hi Max, Thanks for the clarification on DecryptMessage. Updated webrev looks fine. Regards, Valerie On 6/9/2019 7:30 PM, Weijun Wang wrote: Updated webrev at http://cr.openjdk.java.net/~weijun/6722928/webrev.08/ @build-dev guys, I realize I've never included you in this code review. Plea

RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-10 Thread Erik Joelsson
Since JDK-8193255, when we started generating the cacerts file in the build, the build compare baseline builds have started failing. It seems the cacerts binary file has some non determinism built in so it doesn't get generated exactly the same given the same input. This patch adds special hand

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-10 Thread Erik Joelsson
Hello Max, I believe $(call FindSrcDirsForLib, $(MODULE), sspi_bridge) for SRC is the default so you shouldn't need to specify it explicitly, or did you experience some problems with the default that I'm missing? /Erik On 2019-06-09 19:30, Weijun Wang wrote: Updated webrev at http://cr