Re: RFR: 8227397: Add --with-extra-asflags configure option

2019-07-08 Thread Martin Buchholz
To my surprise I checked the default meaning of ASFLAGS in make and found 'ASFLAGS' Extra flags to give to the assembler (when explicitly invoked on a '.s' or '.S' file). $ make -p |& grep -B1 AS.*FLAG # default LINK.S = $(CC) $(ASFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_MACH) -- # defa

RE: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-07-08 Thread Langer, Christoph
Hi Severin, I have a solution for Solaris. In your webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/02/webrev/, make/solaris/makefiles/jsig.make, Line 52:JSIG_OPT_FLAGS = $(OPT_CFLAGS) Should be: JSIG_OPT_FLAGS = -xO4 -g OPT_CFLAGS are the opt flags for the C++ compil

Re: RFR: 8227397: Add --with-extra-asflags configure option

2019-07-08 Thread Severin Gehwolf
Hi Martin, On Mon, 2019-07-08 at 10:42 -0700, Martin Buchholz wrote: > (not really a review ...) > > I'm confused because the assembler is invoked when compiling any sort of > source file - C, C++, or .s/.S. > Wouldn't we want assembler flags passed uniformly, no matter when the > assembler is

Re: RFR: 8227397: Add --with-extra-asflags configure option

2019-07-08 Thread Martin Buchholz
(not really a review ...) I'm confused because the assembler is invoked when compiling any sort of source file - C, C++, or .s/.S. Wouldn't we want assembler flags passed uniformly, no matter when the assembler is invoked? It looks like this patch only affects compilation of .s/.S files in hotspot

RFR: 8227397: Add --with-extra-asflags configure option

2019-07-08 Thread Severin Gehwolf
Hi, Could I please get a review for this patch which adds a new configure option --with-extra-asflags? The issue at hand is that we, Red Hat, need to pass certain extra flags to the assembler when OpenJDK is being compiled. -Wa,--generate-missing-build-notes=yes in our case. That's currently not p

RE: 8227389: Remove unsupported xlc16 compile options on aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported

2019-07-08 Thread Doerr, Martin
+1 Thanks, Martin > -Original Message- > From: build-dev On Behalf Of > Langer, Christoph > Sent: Montag, 8. Juli 2019 15:26 > To: Baesken, Matthias ; Thomas Stüfe > > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > Subject: [CAUTION] RE: 8227389: Remove unsupported

RE: 8227389: Remove unsupported xlc16 compile options on aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported

2019-07-08 Thread Langer, Christoph
Hi Matthias, looks good! Best regards Christoph > -Original Message- > From: build-dev On Behalf Of > Baesken, Matthias > Sent: Montag, 8. Juli 2019 14:00 > To: Thomas Stüfe > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > Subject: [CAUTION] 8227389: Remove unsuppo

Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-08 Thread Severin Gehwolf
Hi Andrew, On Fri, 2019-06-28 at 14:45 +0100, Andrew John Hughes wrote: > On 28/06/2019 10:52, Severin Gehwolf wrote: > > Hi Andrew, > > > > On Thu, 2019-06-27 at 17:36 +0100, Andrew John Hughes wrote: > > > On 22/05/2019 17:34, Severin Gehwolf wrote: > > > > Hi, > > > > > > > > Could I please g

8227389: Remove unsupported xlc16 compile options on aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported

2019-07-08 Thread Baesken, Matthias
Hello, here is a small webrev removing the 2 mentioned options . When compiling jdk/jdk on AIX (using current xlc16 / xlclang) we run into these warnings : warning: 1540-5200 The option "langlvl=c99vla" is not supported. : This option controls variable length arrays / Enables or disables sup

Re: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported

2019-07-08 Thread Thomas Stüfe
I think this is fine for 14. Cheers, Thomas On Mon, Jul 8, 2019 at 9:23 AM Baesken, Matthias wrote: > Hello, when building jdk/jdk on AIX (using the current default > xlc16) I get a ton of warnings : > > warning: 1540-5200 The option "langlvl=c99vla" is not supported. > warning: 1540-5

AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported

2019-07-08 Thread Baesken, Matthias
Hello, when building jdk/jdk on AIX (using the current default xlc16) I get a ton of warnings : warning: 1540-5200 The option "langlvl=c99vla" is not supported. warning: 1540-5200 The option "langlvl=noredefmac" is not supported. The 2 options seem to be gone with the current xlc16