Re: RFR(S) [13] : 8226910 : make it possible to use jtreg's -match via run-test framework

2019-07-18 Thread Igor Ignatyev
David, Misha, thanks for your review, pushed. -- Igor > On Jul 18, 2019, at 10:14 AM, mikhailo.seledt...@oracle.com wrote: > > +1 > > On 7/17/19 9:43 PM, David Holmes wrote: >> Hi Igor, >> >> This seems fine to me. >> >> Thanks, >> David >> >> On 17/07/2019 7:35 am, Igor Ignatyev wrote: >>>

Re: RFR(S) [13] : 8226910 : make it possible to use jtreg's -match via run-test framework

2019-07-18 Thread mikhailo . seledtsov
+1 On 7/17/19 9:43 PM, David Holmes wrote: Hi Igor, This seems fine to me. Thanks, David On 17/07/2019 7:35 am, Igor Ignatyev wrote: can I get a review for this patch? http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html Thanks, -- Igor On Jul 6, 2019, at 11:50 AM, Igor Ign

Re: 8227652: SetupOperatorNewDeleteCheck should discuss deleting destructors

2019-07-18 Thread Kim Barrett
> On Jul 17, 2019, at 10:28 PM, David Holmes wrote: > > Looks fine and trivial to me. Thanks. > Thanks, > David > > On 16/07/2019 5:51 am, Kim Barrett wrote: >> Please review this explanatory comment being added to the description >> of the check for using global operator new/delete in Hotspot