Re: [14] RFR: 8212970: TZ database in "vanguard" format support

2019-07-24 Thread Joe Wang
Thanks Naoto.  Looks good. -Joe On 7/24/19 3:24 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for the review. On 7/24/19 2:57 PM, Joe Wang wrote: Hi Naoto, The method findNegativeSavings method in TzdbZoneRulesProvider.java states that it "Find the minimum negative savings". While the

Re: [14] RFR: 8212970: TZ database in "vanguard" format support

2019-07-24 Thread naoto . sato
Hi Joe, Thank you for the review. On 7/24/19 2:57 PM, Joe Wang wrote: Hi Naoto, The method findNegativeSavings method in TzdbZoneRulesProvider.java states that it "Find the minimum negative savings". While the result is correct since the rules all have the same value for SAVE, I wonder if t

Re: [14] RFR: 8212970: TZ database in "vanguard" format support

2019-07-24 Thread Joe Wang
Hi Naoto, The method findNegativeSavings method in TzdbZoneRulesProvider.java states that it "Find the minimum negative savings". While the result is correct since the rules all have the same value for SAVE, I wonder if that's ideal conceptually. Given a start LDT, shouldn't it be looking for

Mac OS (Mojave / Xcode 10.3) build issue..

2019-07-24 Thread Sundararajan Athijegannathan
Hi, After recent OS and Xcode upgrade (Mojave 10.14.6 and Xcode 10.3), I'm seeing JDK build failures on my machine. Bboth "jdk-dev" and "panama-dev" foreign branch. It is a fresh configure & clean build. "nm" is selected from /usr/local/bin/nm and that is from bintools 2.32 (homebrew installe