Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-16 Thread David Holmes
Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an enhancement which I've identified when working with Processhelper for JDK-8230850. I noticed that ProcessH

Re: [14] Review Request: JDK-8231027 Correct typos

2019-09-16 Thread David Holmes
Hi Sergey, These changes are all fine and trivial. Thanks, David On 17/09/2019 7:50 am, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8231027 Fix: http://cr.openjdk.java.net/~serb/8231027/webrev.00 One common typo is fixed acros

Re: [14] Review Request: JDK-8231027 Correct typos

2019-09-16 Thread Lance Andersen
Looks fine Sergey > On Sep 16, 2019, at 5:50 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8231027 > Fix: http://cr.openjdk.java.net/~serb/8231027/webrev.00 > > One common typo is fixed across a few components lik

[14] Review Request: JDK-8231027 Correct typos

2019-09-16 Thread Sergey Bylokhov
Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8231027 Fix: http://cr.openjdk.java.net/~serb/8231027/webrev.00 One common typo is fixed across a few components like client, build, and hotspot. -- Best regards, Sergey.

Re: [PATCH] Add *.iml to .hgignore and .gitignore

2019-09-16 Thread Erik Joelsson
Hello, The .ignore file is currently in regexp format so new additions should probably be in that format. I don't object to ignoring .iml files. /Erik On 2019-09-15 23:33, Alan Bateman wrote: I think the .ignore files are maintained on build-dev. Note that .idea is already excluded and it