Re: RFR(T/XS) 8231145: [Graal] org.graalvm.compiler.debug.test.DebugContextTest fails because DebugContextTest.testLogging.input is not available

2019-09-17 Thread Igor Veresov
Looks good. igor > On Sep 17, 2019, at 3:45 PM, Ekaterina Pavlova > wrote: > > Hi, > > please review the following change which fixes > org.graalvm.compiler.debug.test.DebugContextTest. > The test fails because it tries to read DebugContextTest.testLogging.input > file which is not

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread David Holmes
Hi Erik, Thanks for the additional details (I can't say I fully understand them :) ). David On 17/09/2019 11:39 pm, Erik Joelsson wrote: Hello, On 2019-09-17 05:59, David Holmes wrote: Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi

RFR(T/XS) 8231145: [Graal] org.graalvm.compiler.debug.test.DebugContextTest fails because DebugContextTest.testLogging.input is not available

2019-09-17 Thread Ekaterina Pavlova
Hi, please review the following change which fixes org.graalvm.compiler.debug.test.DebugContextTest. The test fails because it tries to read DebugContextTest.testLogging.input file which is not available at runtime. The fix copies testLogging.input file into jdk.vm.compiler.tests.jar.

Re: [8u] RFR 8226288 - Upgrade to XCode 10+ for building JDK 8u and 11u

2019-09-17 Thread Derek Keeler
Hi build-dev friends! I'm Derek Keeler, the infrastructure lead on the Java Platform team within Microsoft, working with the AdoptOpenJDK's George Adams and John Oliver. Simon, I have pulled down your jdk8u patches and have built them against macOS Mojave (with a good amount of help from

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread Erik Joelsson
Hello, On 2019-09-17 05:59, David Holmes wrote: Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer,

Re: [14] Review Request: JDK-8231027 Correct typos

2019-09-17 Thread Erik Joelsson
Looks good. /Erik On 2019-09-16 14:50, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8231027 Fix: http://cr.openjdk.java.net/~serb/8231027/webrev.00 One common typo is fixed across a few components like client, build, and

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread David Holmes
Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread Magnus Ihse Bursie
On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an enhancement which I've identified when working with