Re: RFR: JDK-8226585: Improve javac messages for using a preview API

2019-10-03 Thread Joe Darcy
Hi Jan, For future work, consider having a "Preview Methods" tag alongside static, instance, deprecated, etc. Cheers, -Joe On 10/3/2019 2:57 AM, Jan Lahoda wrote: Hi, This is a continuation of Joe's patch from here: https://mail.openjdk.java.net/pipermail/compiler-dev/2019-June/013498.html

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

2019-10-03 Thread Erik Joelsson
Hello Jan, The build change looks ok, but I would recommend this construct for copying the file instead: $(eval $(call SetupCopyFiles, COPY_PREVIEW_FEATURES, \     FILES := $(TOPDIR)/src/java.base/share/classes/jdk/internal/PreviewFeature.java, \     DEST := $(BUILDTOOLS_OUTPUTDIR)/gensrc/ja

RFR: JDK-8226585: Improve javac messages for using a preview API

2019-10-03 Thread Jan Lahoda
Hi, This is a continuation of Joe's patch from here: https://mail.openjdk.java.net/pipermail/compiler-dev/2019-June/013498.html APIs associated with preview features are split into two groups: essential and non-essential. These are marked with an JDK-internal annotation, PreviewFeature, and a