On 2019-10-04 15:16, Erik Joelsson wrote:
On 2019-10-04 04:37, Magnus Ihse Bursie wrote:
On 2019-10-02 17:40, Erik Joelsson wrote:
Hello Magnus,
The change looks good, but should perhaps also include removal of
the few scattered specific instances of LANG=C and LC_ALL=C in the
makefiles:
m
LGTM.
/Magnus
> 8 okt. 2019 kl. 21:24 skrev Erik Joelsson :
>
> In certain Oracle build configurations, the common legal output directory is
> never created, because there are no legal files to put in it. This should not
> make the build fail. This patch makes adding the --legal-notices param
I can’t see how the compilation is dependent on the copy being finished. Since
Erik contributed this it will probably be correct :) but I’d appreciate an
explanation on how this dependency is guaranteed.
Or maybe I’m misunderstanding what this is supposed to do?
/Magnus
> 8 okt. 2019 kl. 17:2
Oh, you are absolutely correct, the dependency is missing.
We need something like this inside "define SetupInterimModule":
$$(BUILD_$1.interim): $(COPY_PREVIEW_FEATURES)
/Erik
On 2019-10-09 01:42, Magnus Ihse Bursie wrote:
I can’t see how the compilation is dependent on the copy being finishe
Looks good.
/Erik
On 2019-10-04 04:52, Magnus Ihse Bursie wrote:
On 2019-10-02 17:45, Martin Buchholz wrote:
I recall years ago running into troubles with regex character ranges,
e.g.
https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges
but my build
