Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-12-05 Thread Henry Jen
OK, so I created an issue[1] for follow up for Windows build and reverted the change in flags-cflags.m4, if nothing else, I’ll push without another webrev pinging that I get an +1 from someone in build-de, Erik? [1] https://bugs.openjdk.java.net/browse/JDK-8235461 Cheers, Henry > On Dec 5, 201

Re: RFR: JDK-8230067: Add optional automatic retry when running jtreg tests

2019-12-05 Thread Philip Race
Looks good to me (and worked fine in my testing). -phil. On 12/5/19, 3:21 PM, Erik Joelsson wrote: The issue with jtreg has now been fixed in b16. Here is an updated webrev: http://cr.openjdk.java.net/~erikj/8230067/webrev.02/index.html /Erik On 2019-08-23 14:10, Erik Joelsson wrote: There

Re: RFR: JDK-8230067: Add optional automatic retry when running jtreg tests

2019-12-05 Thread Erik Joelsson
The issue with jtreg has now been fixed in b16. Here is an updated webrev: http://cr.openjdk.java.net/~erikj/8230067/webrev.02/index.html /Erik On 2019-08-23 14:10, Erik Joelsson wrote: There seems to be a bug in the new jtreg version, so need to hold off on this. /Erik On 2019-08-22 14:22,

Re: JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

2019-12-05 Thread Joe Darcy
Thanks; filed JDK-8235445: "Update boot-jdk.m4 to derive -source/-target from centralized location". -Joe On 12/5/2019 1:16 PM, Erik Joelsson wrote: Fine with me. /Erik On 2019-12-05 09:20, Joe Darcy wrote: On 12/5/2019 9:06 AM, Erik Joelsson wrote: On 2019-12-04 19:29, Joe Darcy wrote: H

Re: JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

2019-12-05 Thread Erik Joelsson
Fine with me. /Erik On 2019-12-05 09:20, Joe Darcy wrote: On 12/5/2019 9:06 AM, Erik Joelsson wrote: On 2019-12-04 19:29, Joe Darcy wrote: Hello, First on the build front, the -source/-target used in the bootstrap build of langtools was stuck at 9; in the change I'm proposing to update it

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-12-05 Thread Mandy Chung
On 12/5/19 12:41 AM, Alan Bateman wrote: On 05/12/2019 08:16, Henry Jen wrote: Hi, Updated webrev[1] reflect comments since last webrev. Vicente had done all the heavy-lifting and hand over to me to finish up. Changes to symbols is reverted, as we expect that only need to be updated in n

Re: JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

2019-12-05 Thread Joe Darcy
On 12/5/2019 9:06 AM, Erik Joelsson wrote: On 2019-12-04 19:29, Joe Darcy wrote: Hello, First on the build front, the -source/-target used in the bootstrap build of langtools was stuck at 9; in the change I'm proposing to update it to 13, the minimum boot JDK: --- old/make/autoconf/boot-jdk

Re: JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

2019-12-05 Thread Erik Joelsson
On 2019-12-04 19:29, Joe Darcy wrote: Hello, First on the build front, the -source/-target used in the bootstrap build of langtools was stuck at 9; in the change I'm proposing to update it to 13, the minimum boot JDK: --- old/make/autoconf/boot-jdk.m4    2019-12-04 19:16:42.209000999 -0800 +

Re: RFR: 8234835 Use UTF-8 charset in make support Java code

2019-12-05 Thread Erik Joelsson
I'm fine with this. /Erik On 2019-12-04 15:30, Dan Smith wrote: On Dec 3, 2019, at 5:24 PM, Jonathan Gibbons wrote: Hi Dan, I think it's a combination of oral tradition and long-standing precedent. Earlier this year, I raised this general issue, partly because of inconsistent use of -enco

Re: JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

2019-12-05 Thread Maurizio Cimadamore
Looks good - I agree we should proactively update this on every release. Maurizio On 05/12/2019 03:29, Joe Darcy wrote: Hello, First on the build front, the -source/-target used in the bootstrap build of langtools was stuck at 9; in the change I'm proposing to update it to 13, the minimum bo

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-12-05 Thread Alan Bateman
On 05/12/2019 08:16, Henry Jen wrote: Hi, Updated webrev[1] reflect comments since last webrev. Vicente had done all the heavy-lifting and hand over to me to finish up. Changes to symbols is reverted, as we expect that only need to be updated in next release by running make/scripts/generate-s

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-12-05 Thread Henry Jen
Hi, Updated webrev[1] reflect comments since last webrev. Vicente had done all the heavy-lifting and hand over to me to finish up. Changes to symbols is reverted, as we expect that only need to be updated in next release by running make/scripts/generate-symbol-data.sh. The jar files are confu