> On Dec 10, 2019, at 9:05 AM, Aleksei Voitylov
> wrote:
>
> Kim,
>
> thank you for the suggestions. Here is an updated webrev:
>
> http://cr.openjdk.java.net/~avoitylov/webrev.8231612.04/
>
> The assembly generated with inline functions is equivalent to that with
> the macros, and the testin
This patch fixes the COMPARE_BUILD baseline. The SVG files generated by
GraphViz are non-deterministic, so adding a sed filter to compensate.
There is also an issue since jpackage was added, where we now have
executables as resources in lib/modules. Those need to be compared as
executables. Wit
We need to customize the image dirs in order to support the new Macos
signing requirements at Oracle. To support this, we need Bundles.gmk to
accept more variable overrides for where the various images are located.
Bug: https://bugs.openjdk.java.net/browse/JDK-8235686
Webrev: http://cr.openjdk
To be able to fully sign and notarize a jdk-bundle on MacOS, the file
Contents/MacOS/libjli.dylib cannot be a symlink. The easy fix is to
simply make it a normal file. Longer term we will evaluate what this
file is actually needed for, but for now, we just need to make the JDK
compatible with t
Hi Erik, Christoph,
thank you!
Rene
On Tue, Dec 10, 2019 at 4:27 PM Langer, Christoph
wrote:
>
> Hi René,
>
> LGTM, too.
>
> I'll sponsor it for you.
>
> Cheers
> Christoph
>
> > -Original Message-
> > From: Erik Joelsson
> > Sent: Dienstag, 10. Dezember 2019 15:35
> > To: René Schünem
Hi René,
LGTM, too.
I'll sponsor it for you.
Cheers
Christoph
> -Original Message-
> From: Erik Joelsson
> Sent: Dienstag, 10. Dezember 2019 15:35
> To: René Schünemann ; Langer, Christoph
>
> Cc: build-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8235585: Enable macOS codesigning for
Looks good.
/Erik
On 2019-12-10 03:44, René Schünemann wrote:
Thank you Christoph.
I have fixed the indentation in NativeCompilation.gmk and removed the
"com.apple.security.cs.disable-executable-page-protection"
entitlement.
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr19/rene/8235585-
Kim,
thank you for the suggestions. Here is an updated webrev:
http://cr.openjdk.java.net/~avoitylov/webrev.8231612.04/
The assembly generated with inline functions is equivalent to that with
the macros, and the testing passed as well.
-Aleksei
On 07/12/2019 02:54, Kim Barrett wrote:
>> On Dec
Thank you Christoph.
I have fixed the indentation in NativeCompilation.gmk and removed the
"com.apple.security.cs.disable-executable-page-protection"
entitlement.
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr19/rene/8235585-mac_notarization/02/
Rene
On Tue, Dec 10, 2019 at 11:25 AM Lange
Hi René,
thanks for doing this.
I agree to Erik's findings, these should be addressed. Other than that, I have
no further points.
It would be good, if this little enhancement can be pushed before Thursday to
make it into JDK14 without special approval.
Best regards
Christoph
> -Original
Hello Erik,
thank you for your review.
On Mon, Dec 9, 2019 at 5:48 PM Erik Joelsson wrote:
>
> Hello René,
>
> Nice to see an OpenJDK solution to this. (Our Oracle solution requires
> too much corp specific customization to really benefit from code sharing
> with a simple codesign based implemen
11 matches
Mail list logo
