Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-23 Thread Phil Race
I am not sure what the right mailing list(s) are for this change. It definitely isn't a core-libs change. I think build-dev may be better. I am also unclear when this failure handler is invoked and how all this machinery works. It is only useful for headful tests and so I'd only want it enable

RE: [11u] RFR: 8232167: Visual Studio install found through --with-tools-dir value is discarded

2019-12-23 Thread Langer, Christoph
Thanks for the review, Martin. > -Original Message- > From: Doerr, Martin > Sent: Montag, 23. Dezember 2019 15:12 > To: Langer, Christoph ; jdk-updates-dev updates-...@openjdk.java.net> > Cc: build-dev > Subject: RE: [11u] RFR: 8232167: Visual Studio install found through --with- > tool

RE: [11u] RFR: 8236500: Windows ucrt.dll should be looked up in versioned WINSDK subdirectory

2019-12-23 Thread Langer, Christoph
Thanks for the review, Martin. > -Original Message- > From: Doerr, Martin > Sent: Montag, 23. Dezember 2019 16:02 > To: Langer, Christoph ; jdk-updates-dev updates-...@openjdk.java.net> > Cc: build-dev > Subject: RE: [11u] RFR: 8236500: Windows ucrt.dll should be looked up in > versione

RE: [11u] RFR: 8236500: Windows ucrt.dll should be looked up in versioned WINSDK subdirectory

2019-12-23 Thread Doerr, Martin
Hi Christoph, looks good. Thanks for fixing this part in 11u. Best regards, Martin > -Original Message- > From: build-dev On Behalf Of > Langer, Christoph > Sent: Montag, 23. Dezember 2019 15:30 > To: jdk-updates-dev > Cc: build-dev > Subject: [11u] RFR: 8236500: Windows ucrt.dll sho

[11u] RFR: 8236500: Windows ucrt.dll should be looked up in versioned WINSDK subdirectory

2019-12-23 Thread Langer, Christoph
Hi, please review a backport of a carveout of JDK-8215445: "Enable building for Windows in WSL" [0]. When building 11u after I've reinstalled Visual Studio and the Windows Devkit to non-default folder locations, I ran into the issue that ucrt.dll would not be correctly resolved, since it sits i

RE: [11u] RFR: 8232167: Visual Studio install found through --with-tools-dir value is discarded

2019-12-23 Thread Doerr, Martin
Hi Christoph, looks good. Thanks for backporting. Best regards, Martin > -Original Message- > From: jdk-updates-dev On > Behalf Of Langer, Christoph > Sent: Montag, 23. Dezember 2019 15:00 > To: jdk-updates-dev > Cc: build-dev > Subject: [11u] RFR: 8232167: Visual Studio install foun

[11u] RFR: 8232167: Visual Studio install found through --with-tools-dir value is discarded

2019-12-23 Thread Langer, Christoph
Hi, please review this simple backport of a simple build system fix which unfortunately did not apply cleanly. It's just context changes that needed to be resolved. I ran into this with jdk11u after I reinstalled my Visual Studio to a non-default folder and used configure option --with-tools-di