Hi Erik and Christoph,
thank you for your reviews.
The added touch works for me too. I have adapted the suggested whitespace fixes.
Here is the updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/04/
Rene
On Wed, Feb 12, 2020 at 8:09 PM Erik Joelsson wro
Ping - any reviews ?
Thanks, Matthias
From: Baesken, Matthias
Sent: Dienstag, 11. Februar 2020 10:24
To: jdk-updates-...@openjdk.java.net; 'build-dev@openjdk.java.net'
Subject: RFR [jdk11]: 8234525: enable link-time section-gc for linux s390x to
remove unused code
Hello , please review the d
On 12/02/2020 22:16, Erik Joelsson wrote:
Hello Christoph,
This patch certainly looks better to me, though I agree it's a bit
hackish to have to filter and rename the stripped.pdb files twice,
once for jmods and again for bundles. I think I'm ok with it for now
though. The future improvement
Hi all,
this small patch changes FindTest.gmk to only include TEST.ROOT files
that actually are present. The motivation for this change is that both
Git and Mercurial supports so called "sparse" checkouts [0][1] (still
somewhat experimental for both, but actively worked on). While
experimenti
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00
> 10 lines changed: 1 ins; 0 del; 9 mod;
Hi all,
could you please review the patch which changes jtreg version used in jdk/jdk
to the latest and greatest -- jtreg 5.0? and as (recently became) usually, this
patch also bumps requiredVersio
Igor,
The change to langtools/TEST.ROOT is OK.
That being said, there are some old entries there which could also be
cleaned up (separately?) These lines probably date from the development
of JDK 9 and the evolution of Project Jigsaw.
20 # Use new module options
21 useNewOptions=true
Looks good.
/Erik
On 2020-02-13 01:17, René Schünemann wrote:
Hi Erik and Christoph,
thank you for your reviews.
The added touch works for me too. I have adapted the suggested whitespace fixes.
Here is the updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bun
Looks good, but could you change the "version" field to "5.0", it should
work now.
/Erik
On 2020-02-13 08:50, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00
10 lines changed: 1 ins; 0 del; 9 mod;
Hi all,
could you please review the patch which changes jtreg ve
Hello Erik,
Looks good. Style wise I try to put closing braces for logical blocks on
a new line, aligned with the opening brace. I think that helps making
the already quite convoluted makefile logic a tad more readable.
/Erik
On 2020-02-13 04:44, Erik Helin wrote:
Hi all,
this small patch
Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and
apparently forgot to replace the webrev, the right is
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with version field
value being the only difference b/w .00 and .01
Thanks,
— Igor
> On Feb 13, 2020, at 9
+1 for the change to test/jaxp/TEST.ROOT.
Best,
Joe
On 2/13/20 10:08 AM, Igor Ignatev wrote:
Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and
apparently forgot to replace the webrev, the right is
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with versi
Looks good.
/Erik
On 2020-02-13 10:08, Igor Ignatev wrote:
Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and
apparently forgot to replace the webrev, the right is
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with version field
value being the only diff
> On Feb 13, 2020, at 7:26 AM, John Paul Adrian Glaubitz
> wrote:
>
> Hello!
>
> Hotspot fails to build on linux-sparc after 8238281 due to the redefinition
> of offset_of() in src/hotspot/share/prims/jvm.cpp [1]:
>
> /home/glaubitz/jdk/src/hotspot/cpu/sparc/macroAssembler_sparc.hpp: In static
Great. I'll push it tomorrow.
/Christoph
> -Original Message-
> From: Erik Joelsson
> Sent: Donnerstag, 13. Februar 2020 18:18
> To: René Schünemann ; Langer, Christoph
>
> Cc: build-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8238534
>
> Looks good.
>
> /Erik
>
> On 2020-02-13 01:1
On 13/02/2020 11:48, Baesken, Matthias wrote:
> Ping - any reviews ?
>
> Thanks, Matthias
>
> From: Baesken, Matthias
> Sent: Dienstag, 11. Februar 2020 10:24
> To: jdk-updates-...@openjdk.java.net; 'build-dev@openjdk.java.net'
>
> Subject: RFR [jdk11]: 8234525: enable link-time section-gc f
I searched the code base for mentions of old gcc workarounds, and tried to
remedy them now that they were not needed.
If it turns out that they still were needed, by all means, revert that part of
the patch.
/Magnus
13 feb. 2020 kl. 20:35 skrev Kim Barrett :
>> On Feb 13, 2020, at 7:26 AM,
Hello,
The fix to make idea.sh support both git and mercurial had the
unfortunate side effect of bailing out completely if neither was found.
This happens to be the case when we run our build system tests (which
includes running idea.sh) in our distributed test environment. I think
idea.sh sh
> On Feb 13, 2020, at 5:21 PM, Magnus Ihse Bursie
> wrote:
>
> I searched the code base for mentions of old gcc workarounds, and tried to
> remedy them now that they were not needed.
>
> If it turns out that they still were needed, by all means, revert that part
> of the patch.
I think the
Hi
Could you please review following fix which extend JibArtifactManager to
support download and installation of artifacts with layout different from maven
style.
It is planned that user provide name and properties to resolve layout using
default or jib manager. There are no tests which use th
19 matches
Mail list logo
