Re: Mach5 test failure when testing JDK-8237192

2020-02-20 Thread David Holmes
On 21/02/2020 6:30 am, Daniel D. Daugherty wrote: Greetings, I filed two relevant bugs when I swept the JDK15 CI this AM:     JDK-8239566 gtest/GTestWrapper.java fails due to "libstlport.so.1: open failed: No such file or directory"     https://bugs.openjdk.java.net/browse/JDK-8239566    

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Ioi Lam
I am just wondering, what are the practical reasons for including two libjvms in the same JDK? We had server/client VMs in the past so we can use the same JDK for running "throughput" jobs vs "desktop/interactive" jobs. But that's no longer needed with advances in tier compilation, etc. Than

Re: Mach5 test failure when testing JDK-8237192

2020-02-20 Thread Daniel D. Daugherty
Greetings, I filed two relevant bugs when I swept the JDK15 CI this AM:     JDK-8239566 gtest/GTestWrapper.java fails due to "libstlport.so.1: open failed: No such file or directory"     https://bugs.openjdk.java.net/browse/JDK-8239566     JDK-8239565 sa/ClhsdbJhisto.java failed due to "asser

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Magnus Ihse Bursie
> 20 feb. 2020 kl. 16:13 skrev Bob Vandette : > > Keep in mind that any change here will have an impact on the jlink option > that allows for the > selection of JVM. > > Jlink Plugin Name: vm > Option: --vm= > Description: Select the HotSpot VM in the output image. Default is all Good point.

Re: RFR: JDK-8239450 Overhaul JVM feature handling in configure

2020-02-20 Thread Erik Joelsson
Hello, On 2020-02-20 01:05, Magnus Ihse Bursie wrote: On 2020-02-19 16:00, Erik Joelsson wrote: Hello Magnus, This is certainly a nice improvement. Thanks! It's been long overdue... It looks good to me. I have some comments on implementation details, but nothing serious enough to require a

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Bob Vandette
Keep in mind that any change here will have an impact on the jlink option that allows for the selection of JVM. Jlink Plugin Name: vm Option: --vm= Description: Select the HotSpot VM in the output image. Default is all Bob. > On Feb 20, 2020, at 10:04 AM, Magnus Ihse Bursie > wrote: > > On

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Magnus Ihse Bursie
On 2020-02-20 12:52, Baesken, Matthias wrote: run a separate task with "configure --with-jvm-variants=minimal && make hotspot". Hello, this would , as far as I know, not produce the same result jdk image with both minimal+server libjvm in the image . So the proposed change sounds a bit

RE: Is anyone still building multiple JVMs?

2020-02-20 Thread Baesken, Matthias
> run a separate task with "configure --with-jvm-variants=minimal && > make hotspot". Hello, this would , as far as I know, not produce the same result jdk image with both minimal+server libjvm in the image . So the proposed change sounds a bit like a workaround, but not a real replace

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Magnus Ihse Bursie
On 2020-02-19 16:59, Baesken, Matthias wrote: Hi Magnus, yes we do. We build (on Linux only currently) "--with-jvm-variants=minimal,server" in our central builds to test that minimal is still working and that is was not destroyed by recent changes . Best Regards, Matthias Is this just

RE: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Langer, Christoph
Hi Sergey, from what I can see your proposed changes seem to make sense, given that XSetForeground and XSetBackground do their job. The change itself comes from Ichiroh-san, I only helped to review/sponsor it at the time and ran a few tests in our infrastructure. I suggest you prepare a patch

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Ichiroh Takiguchi
Hello Sergey. I'm not sure if I understand what you want to change... XCreateGC: The colors are created upper code, they will be overwritten. XSetBackground: I'm sorry, I have no idea about XSetBackground(), I thought background might have default value, But I could not find out the doc. Ich

Re: RFR: JDK-8239450 Overhaul JVM feature handling in configure

2020-02-20 Thread Magnus Ihse Bursie
On 2020-02-19 16:00, Erik Joelsson wrote: Hello Magnus, This is certainly a nice improvement. Thanks! It's been long overdue... It looks good to me. I have some comments on implementation details, but nothing serious enough to require a new webrev. Instead of using "echo $foo | sed 's/,/ /

RE: Mach5 test failure when testing JDK-8237192

2020-02-20 Thread Langer, Christoph
Thanks, David for the information. As I don't see a relation from the crash to my change (I didn't touch any hotspot code at least), I guess I'm confident enough to push my patch. If worse comes to worse there's still the option to back it out again... Best regards Christoph > -Original Me

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread John Paul Adrian Glaubitz
On 2/20/20 9:32 AM, Magnus Ihse Bursie wrote: >>> I think we should also ask -- is anyone actually shipping a JDK build with >>> multiple libjvm variants in it? >> Debian and therefore Ubuntu always build and ship both Hotspot and Zero on >> every architecture which supports both [1]. > But that i

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Magnus Ihse Bursie
On 2020-02-20 09:28, John Paul Adrian Glaubitz wrote: On 2/20/20 9:24 AM, Ioi Lam wrote: I think we should also ask -- is anyone actually shipping a JDK build with multiple libjvm variants in it? Debian and therefore Ubuntu always build and ship both Hotspot and Zero on every architecture whic

Re: Mach5 test failure when testing JDK-8237192

2020-02-20 Thread David Holmes
Hi Christoph, The Solaris failure looks like an infra issue. The test failure is a crash - info below. I don't see any open, or recently fixed, bugs for the same crash. David - # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/scratch/mesos/slave

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread John Paul Adrian Glaubitz
On 2/20/20 9:24 AM, Ioi Lam wrote: > I think we should also ask -- is anyone actually shipping a JDK build with > multiple libjvm variants in it? Debian and therefore Ubuntu always build and ship both Hotspot and Zero on every architecture which supports both [1]. Adrian > [1] https://packages.d

Re: Is anyone still building multiple JVMs?

2020-02-20 Thread Ioi Lam
I think we should also ask -- is anyone actually shipping a JDK build with multiple libjvm variants in it? I guess people may be building multiple variants during testing just because it's convenient (and requires less time), but if this is the only reason, then it doesn't seem to be worth the

Mach5 test failure when testing JDK-8237192

2020-02-20 Thread Langer, Christoph
Hi, I tested my change for JDK-8237192 in the submit repo. I got this back. Can anybody from Oracle please have a look whether the failures could be related to my patch? At first sight and from the information I can see here, I don’t see the relation… Thanks Christoph From: do-not-re...@oracl