Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Kim Barrett
> On Mar 10, 2020, at 10:51 AM, Magnus Ihse Bursie > wrote: >>> Nits: >>> >>> *) src/hotspot/share/gc/shared/gcConfig.cpp changes are a bit strange: >>> - Epsilon should not ever be selected by ergonomics >>> - Why ZGC is selected before Shenandoah? [Oh, what a can of worms that >>> one is

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Kim Barrett
> On Mar 10, 2020, at 7:22 PM, David Holmes wrote: > Also I'm not at all clear what happens if the only GC configured is one of > the experimental GCs for which we would normally have to set > -XX:+UnlockExperimentalVMOptions ?? Yes, it seems wrong to ever select an experimental GC by default.

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Kim Barrett
> On Mar 10, 2020, at 10:53 AM, Magnus Ihse Bursie > wrote: > > On 2020-03-09 21:37, Kim Barrett wrote: >>> On Mar 9, 2020, at 4:30 AM, Magnus Ihse Bursie >>> wrote: >>> >>> When reworking the JVM feature handling, I wanted to try to compile Hotspot >>> with various features enabled/disabled

Re: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-10 Thread Junyuan Zheng
Hi Erik, Magnus, Thank you for reviewing this. Please let me know what's the next step and if you'd like me to help with backporting this change or anything. Thanks, Junyuan From: Erik Joelsson Sent: Friday, February 28, 2020 6:26 AM To: Magnus Ihse Bursie ; Junyuan Zheng ; build-dev@open

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread David Holmes
On 11/03/2020 12:51 am, Magnus Ihse Bursie wrote: On 2020-03-09 10:10, David Holmes wrote: Hi Magnus, On 9/03/2020 6:30 pm, Magnus Ihse Bursie wrote: When reworking the JVM feature handling, I wanted to try to compile Hotspot with various features enabled/disabled. I quickly found out that it

Re: RFR: JDK-8240820 Replace AC_ARG_ENABLE with UTIL_ARG_ENABLE

2020-03-10 Thread Erik Joelsson
Hello Magnus, This looks very good and will certainly make it easier to write good --enable- flags. I would only find one mistake: jdk-options.m4:533: double space /Erik On 2020-03-10 07:22, Magnus Ihse Bursie wrote: The function AC_ARG_ENABLE provided by autoconf is a very bare-bones funct

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Magnus Ihse Bursie
On 2020-03-09 21:37, Kim Barrett wrote: On Mar 9, 2020, at 4:30 AM, Magnus Ihse Bursie wrote: When reworking the JVM feature handling, I wanted to try to compile Hotspot with various features enabled/disabled. I quickly found out that it's not really possible to build hotspot without the seri

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Magnus Ihse Bursie
On 2020-03-09 16:28, Erik Joelsson wrote: On 2020-03-09 02:20, Aleksey Shipilev wrote: On 3/9/20 10:10 AM, David Holmes wrote: On 9/03/2020 6:30 pm, Magnus Ihse Bursie wrote: When reworking the JVM feature handling, I wanted to try to compile Hotspot with various features enabled/disabled. I

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

2020-03-10 Thread Magnus Ihse Bursie
On 2020-03-09 10:10, David Holmes wrote: Hi Magnus, On 9/03/2020 6:30 pm, Magnus Ihse Bursie wrote: When reworking the JVM feature handling, I wanted to try to compile Hotspot with various features enabled/disabled. I quickly found out that it's not really possible to build hotspot without the

RFR: JDK-8240820 Replace AC_ARG_ENABLE with UTIL_ARG_ENABLE

2020-03-10 Thread Magnus Ihse Bursie
The function AC_ARG_ENABLE provided by autoconf is a very bare-bones function, which needs a lot of boilerplate code to do the right thing. We have duplicated this code all over the place, often with bugs or omissions of functionality. This patch introduces a new UTIL_ARG_ENABLE which sets up

RE: 11u RFR: 8232569: Use test image from different jib profile for testing

2020-03-10 Thread Lindenmaier, Goetz
Hi, +1 I think this is a candidate for the label "openjdk-na" then. Best regards, Goetz. > -Original Message- > From: jdk-updates-dev On > Behalf Of Langer, Christoph > Sent: Montag, 9. März 2020 17:29 > To: Erik Joelsson ; jdk-updates- > d...@openjdk.java.net > Cc: build-dev > Subje