Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/15/20 06:00, Magnus Ihse Bursie wrote:
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java
Looks fine Magnus; thanks,
-Joe
On 4/15/2020 1:18 AM, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation
messages, that are trivial to fix and might hide more tricky issues.
This patch
http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
> 35 lines changed: 26 ins; 0 del; 10 mod
Hi all,
8233827[1] which added screenshots to so-called failure handler had an
unexpected side-effect on linux, where users might observer flashes each time a
screenshot is taken, which, to put i
Thanks Mandy. I'll add bug id next to @ignore before push.
Thanks,
-Sundar
On 16/04/20 2:50 am, Mandy Chung wrote:
This looks okay to me.
Can you add the bug ID next to @ignore that will make it easier to
find the JBS issue? These test bugs are filed with P4 but I think
they should be fix
Thanks for spotting this Magnus! I'll fix this before push.
Thanks.
-Sundar
On 15/04/20 10:44 pm, Magnus Ihse Bursie wrote:
On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote:
Please review.
Nashorn script engine modules (jdk.scripting.nashorn,
jdk.scripting.nashorn.shell) a
This looks okay to me.
Can you add the bug ID next to @ignore that will make it easier to find
the JBS issue? These test bugs are filed with P4 but I think they
should be fixed in 15.
Mandy
On 4/15/20 8:56 AM, sundararajan.athijegannat...@oracle.com wrote:
Please review.
Nashorn script e
On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote:
Please review.
Nashorn script engine modules (jdk.scripting.nashorn,
jdk.scripting.nashorn.shell) and jjs tool are removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8241749
JEP: https://openjdk.java.net/jeps/372
CSR: h
+1
> On Apr 15, 2020, at 12:56 PM, sundararajan.athijegannat...@oracle.com wrote:
>
> Please review.
>
> Nashorn script engine modules (jdk.scripting.nashorn,
> jdk.scripting.nashorn.shell) and jjs tool are removed.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8241749
>
> JEP: https://op
Please review.
Nashorn script engine modules (jdk.scripting.nashorn,
jdk.scripting.nashorn.shell) and jjs tool are removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8241749
JEP: https://openjdk.java.net/jeps/372
CSR: https://bugs.openjdk.java.net/browse/JDK-8241751
Webrev: http://cr.op
Looks good.
/Erik
On 2020-04-15 01:18, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation
messages, that are trivial to fix and might hide more tricky issues.
This patch handles the "n
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java compared to v01)
/Magnus
On 2020-04-15 14:30, Magnus Ihse Bursie wrote:
On 2020-04-15 12:59, P
On 2020-04-15 12:59, Prasanta Sadhukhan wrote:
Hi Magnus,
Why can't we just use modelToView2D() to get Rectangle2D and then cast
to Rectangle tobe used in scrollRectToVisible() or else use
(int)Rectangle2D.getX(), (int)getY(), getWidth(), getHeight() to
construct a new Rectangle()?
Casting
Hi Magnus,
Why can't we just use modelToView2D() to get Rectangle2D and then cast
to Rectangle tobe used in scrollRectToVisible() or else use
(int)Rectangle2D.getX(), (int)getY(), getWidth(), getHeight() to
construct a new Rectangle()?
Regard
Prasanta
On 15-Apr-20 3:35 PM, Magnus Ihse Bursie
Hi swing-dev,
Do you have any other suggestions for how to resolve the deprecation of
modelToView() in this code?
Basically, the code does this:
Rectangle rect = source.modelToView(offset);
source.scrollRectToVisible(rect);
but scrollRectToVisible() requires a Rectangle (a subt
Hi Magnus,
This one sounds like it needs a Swing/Java2D developer to review it :)
Cheers,
David
On 15/04/2020 7:13 pm, Magnus Ihse Bursie wrote:
After JDK-8242804, a few places remain which are using deprecated
methods. They too should be fixed, and the deprecation warning should no
longer be
Hi Magnus,
This all looks good to me.
Thanks,
David
On 15/04/2020 6:18 pm, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation messages,
that are trivial to fix and might hide more trick
After JDK-8242804, a few places remain which are using deprecated
methods. They too should be fixed, and the deprecation warning should no
longer be disabled.
This patch presupposes the fix for JDK-8242804 has been applied
(otherwise we cannot turn the deprecation warning back on).
Some brie
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation messages,
that are trivial to fix and might hide more tricky issues.
This patch handles the "new Integer(42)" pattern of explicit boxing,
which is deprecated. I
On 2020-04-15 02:34, serguei.spit...@oracle.com wrote:
Hi Magnus,
It looks good to me.
Thanks for the review, Serguei!
/Magnus
Thanks,
Serguei
On 4/14/20 14:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-8241618-fix-
On 2020-04-14 23:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-8241618-fix-unchecked-warnings-for-agent/webrev.02/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Metadata.java.frames.html
Copyright was updated, bu
20 matches
Mail list logo
