Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Thanks, that looks much better to me. /Erik On 2020-04-16 10:02, Igor Ignatyev wrote: Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Thanks, -- Igor On

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Thanks for your review, Sergey. -- Igor > On Apr 16, 2020, at 1:43 AM, Sergey Bylokhov > wrote: > > Looks fine. > > On 4/15/20 10:22 pm, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 >>> 35 lines changed: 26 ins; 0 del; 10 mod >> Hi all, >> 8233827[1] which

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Thanks, -- Igor > On Apr 16, 2020, at 6:17 AM, Eri

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

Looks fine Erik; thanks, -Joe On 4/16/2020 9:54 AM, Erik Joelsson wrote: JDK 14 is now GA. The minimum boot JDK version for mainline/JDK 15 should be bumped to this version. Bug: https://bugs.openjdk.java.net/browse/JDK-8242863 Webrev: http://cr.openjdk.java.net/~erikj/8242863/webrev.01/inde

RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

JDK 14 is now GA. The minimum boot JDK version for mainline/JDK 15 should be bumped to this version. Bug: https://bugs.openjdk.java.net/browse/JDK-8242863 Webrev: http://cr.openjdk.java.net/~erikj/8242863/webrev.01/index.html /Erik

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Looks ok to me. Would it be possible to break up the long lines a bit to improve readability? Backslash escape for newlines should work in properties files. /Erik On 2020-04-15 22:22, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 35 lines changed: 26 ins; 0 de

RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

This is the final part of removing all warnings from the build of jdk.hotspot.agent. This patch includes a number of non-trivial fixes for the few remaining unchecked warnings. The good news is that with this fix (and after the recent removal of Nashorn and rmic), the JDK build is finally comp

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Looks fine. On 4/15/20 10:22 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 35 lines changed: 26 ins; 0 del; 10 mod Hi all, 8233827[1] which added screenshots to so-called failure handler had an unexpected side-effect on linux, where users might observer