Hi Magnus,
That all seems reasonable to me.
Thanks,
David
-
On 16/04/2020 10:47 pm, Magnus Ihse Bursie wrote:
This is the final part of removing all warnings from the build of
jdk.hotspot.agent. This patch includes a number of non-trivial fixes for
the few remaining unchecked warnings.
Hi Magnus,
This looks pretty good to me.
I hope, Joe gave some insight for Comparable's.
Thanks,
Serguei
On 4/16/20 05:47, Magnus Ihse Bursie wrote:
This is the final part of removing all warnings from the build of
jdk.hotspot.agent. This patch includes a number of non-trivial fixes
for the
With Nashorn removed, the bootcycle build is now broken for builds that
process markdown files for docs or man pages. Same goes for building
with with a recent enough JDK 15 as your bootjdk. While a long term
solution is being worked on, we need something to keep our CI builds
from failing. For
Hello Jiwon,
Are you able to build a native JDK for the x86 platform you are running
the build on or is that giving the same errors?
Since JDK 9, when cross compiling, we need a native JDK to run some of
the build steps with (jmod and jlink mainly). This native JDK (referred
to as the "build
Is the ARM compiler on your path?
I use the —with-devkit configure option to point to the compiler.
Bob.
> On Apr 20, 2020, at 5:04 PM, Choe, Jiwon wrote:
>
> Hello all,
>
> I'm trying to cross-compile OpenJDK 14 to target arm-linux-gnueabihf, and
> the build is failing for me with these err
Hello all,
I'm trying to cross-compile OpenJDK 14 to target arm-linux-gnueabihf, and
the build is failing for me with these errors:
=== Output from failing command(s) repeated here ===
* For target buildjdk_hotspot_variant-server_libjvm_objs_os_linux_x86.o:
/home/sim32/jdk14/jdk14/src/hotspot/os_
Hello,
On 4/16/2020 5:47 AM, Magnus Ihse Bursie wrote:
[snip]
The tricky one here is the helper TableModelComparator. This one took
me a while to wrap my head around. It implements Comparator, but the
compare() method takes "rows" from the model, which are just expressed
as Objects, and left t
(adding build-dev)
Hello Alexey,
The SetupJdkExecutable and SetupJdkLibrary macros are designed to find
the correct source dirs automatically as long as they follow the
standard naming. In this case you are adding some extra with the
"common" dir as well as reusing some src dirs between multi
I've looked at the benchmarks that move from explicit constructors to
autoboxing and don't think we'll see any difference in behavior: all
usage during setup, and benchmarks don't seem to accidentally depend on
identity.
LGTM.
/Claes
On 2020-04-20 15:01, Erik Joelsson wrote:
This looks good to
This looks good to me, but I would like to hear from someone who knows
the benchmarks to confirm that nothing relevant to the tests was lost
when introducing autoboxing instead of explicit constructors in any of
the cases.
/Erik
On 2020-04-20 04:51, Magnus Ihse Bursie wrote:
This patch addres
Looks good.
/Erik
On 2020-04-20 02:20, Magnus Ihse Bursie wrote:
The failure handler has two places where deprecated methods are used.
This results in warnings that are not possible to suppress. This patch
fixes the code in those places.
This patch is part of the ongoing effort to make the e
This patch addresses the warnings deprecation and unchecked, which are
impossible to fully suppress.
With this patch, the test-image can be built fully without warnings.
The patch updates non-critical code to use modern solutions for
deprecated methods, where possible. Tested methods have been
Hi Magnus,
LGTM!
Thanks,
David
On 20/04/2020 7:20 pm, Magnus Ihse Bursie wrote:
The failure handler has two places where deprecated methods are used.
This results in warnings that are not possible to suppress. This patch
fixes the code in those places.
This patch is part of the ongoing effo
The failure handler has two places where deprecated methods are used.
This results in warnings that are not possible to suppress. This patch
fixes the code in those places.
This patch is part of the ongoing effort to make the entire build free
of warnings.
Bug: https://bugs.openjdk.java.net/
14 matches
Mail list logo
